Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing latest image is broken #1952

Closed
pavolloffay opened this issue Nov 29, 2019 · 8 comments · Fixed by #1953, #2418 or #2419
Closed

Publishing latest image is broken #1952

pavolloffay opened this issue Nov 29, 2019 · 8 comments · Fixed by #1953, #2418 or #2419
Labels

Comments

@pavolloffay
Copy link
Member

Publishing latest image on merge to master is broken https://hub.docker.com/repository/docker/jaegertracing/jaeger-collector

Also we do not publish the image per commit to snapshot repository https://hub.docker.com/repository/docker/jaegertracing/jaeger-collector-snapshot

@pavolloffay
Copy link
Member Author

@yurishkuro
Copy link
Member

Looks like it.

#1953 might fix it.

@yurishkuro
Copy link
Member

yurishkuro commented Nov 30, 2019

@pavolloffay I think snapshots are fixed, but it seems that in the main repo in Docker Hub the latest tag is applied to the latest commit on master. This feels rather dangerous, we already have snapshots for unreleased builds, I would expect in the main repos the latest to refer to the latest official release, i.e. 1.15.1 right now.

@yurishkuro yurishkuro reopened this Nov 30, 2019
@pavolloffay
Copy link
Member Author

Note that before we were publishing latest as really the latest code in master. The snapshot repository does not have latest tag, one has to always use the commit SHA as the tag.

People should not depend in latest anyway, but it is a great way to share latest changes if one wants to use them.

@yurishkuro
Copy link
Member

My proposal is to have latest in both repos:

  • in the main repo it points to the latest released version
  • in the snapshop repo it points to the latest commit on master

This provides both better safety and flexibility.

@pavolloffay
Copy link
Member Author

pavolloffay commented Dec 3, 2019

Sounds fine to me, although to be consistent with the operator repo I would prefer to have master tag as part of the main repository. It also easier for users to change.

The main motivation is also to get people using latest features before they are released to have more stable releases. Using a nonstandard tag name might cause less adoption.

We should also document this in https://www.jaegertracing.io/download/.

The requirement for snapshot repository was to be able to archived docker distribution for every commit.

See that people are expecting latest as the latest master #1951 (comment)

@asuffield
Copy link

I will just note that this is now failing again, the travis builds are reporting:

+docker push jaegertracing/jaeger-agent
The push refers to repository [docker.io/jaegertracing/jaeger-agent]
a40bc8102dba: Preparing
ce821040ffa8: Preparing
denied: requested access to the resource is denied

@jpkrohling
Copy link
Contributor

Fixed by #2419.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants