Added host to docker login command #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
pavolloffay
reviewed
Aug 26, 2020
| @@ -33,7 +33,7 @@ fi | |||
|
|
|||
| # Do not enable echo before the `docker login` command to avoid revealing the password. | |||
| set -x | |||
| docker login -u $DOCKER_USER -p $DOCKER_PASS | |||
| docker login docker.io -u $DOCKER_USER -p $DOCKER_PASS | |||
There was a problem hiding this comment.
docker.io redirects to docker.com shouldn't the com domain be used?
There was a problem hiding this comment.
The image is tagged for docker.io by default. When pushing docker.io/jaegertracing/...., the credentials for docker.io are used.
pavolloffay
approved these changes
Aug 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #2418 +/- ##
==========================================
- Coverage 95.57% 95.56% -0.02%
==========================================
Files 208 208
Lines 10676 10678 +2
==========================================
Hits 10204 10204
- Misses 400 401 +1
- Partials 72 73 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling [email protected]
Which problem is this PR solving?
Short description of the changes
docker logincommand.