Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minified css doesn't work properly under retina display #490

Closed
rht opened this issue Mar 13, 2015 · 6 comments
Closed

minified css doesn't work properly under retina display #490

rht opened this issue Mar 13, 2015 · 6 comments
Labels
Milestone

Comments

@rht
Copy link

rht commented Mar 13, 2015

One case when it happened https://ripplelabs.atlassian.net/browse/RT-3235

Hopefully you guys can reproduce this under a more isolated env.

@jakubpawlowicz
Copy link
Collaborator

Can you be any more specific? Even a link to CSS source would help.

@rht
Copy link
Author

rht commented Mar 13, 2015

This is the css file specific to the landing page mentioned, https:/ripple/ripple-client/blob/develop/src/less/ripple/landing.less. Specifically the ones for bg_title.png.
I think this is the line that specifies the background color https:/ripple/ripple-client/blob/develop/src/less/ripple/landing.less#L50

@rht
Copy link
Author

rht commented Mar 13, 2015

It appears that the two .landingContainer's are minified into .landingContainer,.t-tou .landingContainer{background:#fff!important}

@jakubpawlowicz
Copy link
Collaborator

That helps a lot! I'll take a look and get back to you.

@jakubpawlowicz
Copy link
Collaborator

@rht I know now where the problem is. In the meantime you can work around it by using --skip-shorthand-compacting switch.

@jakubpawlowicz jakubpawlowicz added this to the 3.2 milestone Mar 16, 2015
@rht
Copy link
Author

rht commented Mar 18, 2015

Thanks, looking forward to what the fix is like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants