Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip-compile broken with pip 19.0 #714

Closed
demosdemon opened this issue Jan 22, 2019 · 10 comments · Fixed by #715
Closed

pip-compile broken with pip 19.0 #714

demosdemon opened this issue Jan 22, 2019 · 10 comments · Fixed by #715

Comments

@demosdemon
Copy link

Describe the issue briefly here.

Environment Versions
  1. OS Type
    darwin
  2. Python version: $ python -V
    Python 2.7.15
  3. pip version: $ pip --version
    pip 19.0 from /Users/brandon/src/images/.venv/lib/python2.7/site-packages/pip (python 2.7)
  4. pip-tools version: $ pip-compile --version
    pip-compile, version 3.2.0
Steps to replicate
$ pip-compile --generate-hashes --upgrade --header --index --annotate --output-file $@ $<
Traceback (most recent call last):
  File "/Users/brandon/src/images/.venv/bin/pip-compile", line 10, in <module>
    sys.exit(cli())
  File "/Users/brandon/src/images/.venv/lib/python2.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/Users/brandon/src/images/.venv/lib/python2.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/Users/brandon/src/images/.venv/lib/python2.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/brandon/src/images/.venv/lib/python2.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/Users/brandon/src/images/.venv/lib/python2.7/site-packages/piptools/scripts/compile.py", line 130, in cli
    repository = PyPIRepository(pip_options, session)
  File "/Users/brandon/src/images/.venv/lib/python2.7/site-packages/piptools/repositories/pypi.py", line 62, in __init__
    process_dependency_links=pip_options.process_dependency_links,
AttributeError: Values instance has no attribute 'process_dependency_links'
@impredicative
Copy link

impredicative commented Jan 22, 2019

I'm having the same error when running pip-compile under Python 3.6.7, pip-tools==3.2.0, and pip==19.0. The problem doesn't happen with pip==18.1.

@atugushev
Copy link
Member

atugushev commented Jan 22, 2019

Thanks for the report! It seems --process-dependency-links is not supported since pypa/pip#6060

@atugushev atugushev mentioned this issue Jan 22, 2019
3 tasks
@NejcZupec
Copy link

We have the same issue with Python 2.7.15 and 3.7.1, pip-compile-multi==1.2.1 and pip==19.0.

The issue was fixed with:
pip install -U pip==18

@impredicative
Copy link

I don't see a new pypi release out yet for pip-tools, so I don't know why this was closed so soon.

@atugushev
Copy link
Member

atugushev commented Jan 23, 2019

@impredicative
It is the GitHub's behavior by default. See https://github.blog/2013-05-14-closing-issues-via-pull-requests/.

@impredicative
Copy link

Well, so let's reopen it until the issue is actually resolved. Or should users file a new issue? Ridiculous automated actions are no justification for disregarding commonsense.

@vphilippon
Copy link
Member

vphilippon commented Jan 23, 2019

Hello @impredicative,

I'll be making a release to pypi soon, worst case this evening (EST). Quite a busy day today.

Our (my) current approach is to try to make releases a soon as possible once something gets in, which alleviates this "limbo" situation. Although, if you have an idea to track fixed-but-unreleased issues with Github system, I'd be sincerely happy to hear it (maybe as a separate issue for visibility on the discussion).

Cheers!

fdemmer added a commit to fdemmer/ansible_roles that referenced this issue Jan 24, 2019
fdemmer added a commit to fdemmer/ansible_roles that referenced this issue Jan 24, 2019
@vphilippon
Copy link
Member

Had a small pipeline issue last night (#716), I'll make a 3.3.1 release ASAP

@vphilippon
Copy link
Member

Done: https://pypi.org/project/pip-tools/3.3.1/

Cheers!

@jedie
Copy link

jedie commented Jan 25, 2019

Great! It works here, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants