Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the decrypt call to use the v2+ signature #6

Merged

Conversation

mjneth
Copy link
Collaborator

@mjneth mjneth commented Apr 11, 2023

Change is required to work with v2+ of the python google API changes for use in drbot

Copy link
Owner

@maroux maroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait other requirements.txt files need to be re-compiled as well.

@mjneth
Copy link
Collaborator Author

mjneth commented Apr 11, 2023

wait other requirements.txt files need to be re-compiled as well.

Do you have a set of commands you run for the necessary steps you could share? That might be quicker so we can document what your dev and release flow is for this repo.

@maroux
Copy link
Owner

maroux commented Apr 11, 2023

wait other requirements.txt files need to be re-compiled as well.

Do you have a set of commands you run for the necessary steps you could share? That might be quicker so we can document what your dev and release flow is for this repo.

make pip_compile didn't work?

@mjneth
Copy link
Collaborator Author

mjneth commented Apr 12, 2023

wait other requirements.txt files need to be re-compiled as well.

Do you have a set of commands you run for the necessary steps you could share? That might be quicker so we can document what your dev and release flow is for this repo.

make pip_compile didn't work?

Ah hadn't checked the make file. It's not working at the moment but i'm trying to work through the issues. Seems like maybe it's related to conflicting package versions or newer package versions not working since it looks like this code base hasn't been touched in 4 years.

So far:

  • Had to pin setuptools==58 to fix error in ipdb setup command: use_2to3 is invalid.
  • Getting ERROR: No matching distribution found for setuptools>=40.8.0 though adding --no-build-isolation to the pip-compile command to resolve that but then it started erroring on other packages ERROR: Could not find a version that satisfies the requirement google-cloud-kms>=2. It seems to be the --no-index option causing it.

Will continue to work through these to figure out what's wrong and get the readme updated with any necessary changes.

@mjneth
Copy link
Collaborator Author

mjneth commented Apr 12, 2023

wait other requirements.txt files need to be re-compiled as well.

Do you have a set of commands you run for the necessary steps you could share? That might be quicker so we can document what your dev and release flow is for this repo.

make pip_compile didn't work?

Ah hadn't checked the make file. It's not working at the moment but i'm trying to work through the issues. Seems like maybe it's related to conflicting package versions or newer package versions not working since it looks like this code base hasn't been touched in 4 years.

So far:

  • Had to pin setuptools==58 to fix error in ipdb setup command: use_2to3 is invalid.
  • Getting ERROR: No matching distribution found for setuptools>=40.8.0 though adding --no-build-isolation to the pip-compile command to resolve that but then it started erroring on other packages ERROR: Could not find a version that satisfies the requirement google-cloud-kms>=2. It seems to be the --no-index option causing it.

Will continue to work through these to figure out what's wrong and get the readme updated with any necessary changes.

I thought it might be related to pip>20 so I went back to pip==19 but got a new error (jazzband/pip-tools#714) but going all the way back to pip==18 and pip-tools==3.2.0 made it work.

Was this codebase a temporary measure like the forked terraform provider? Do other options exist now so we don't need to maintain this anymore?

@mjneth mjneth requested a review from maroux April 12, 2023 14:19
@maroux maroux merged commit 741883e into maroux:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants