Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting the app with docker-compose up is failing because of version mismatch. #9442

Closed
1 task done
pmverma opened this issue Mar 17, 2019 · 3 comments · Fixed by #9488
Closed
1 task done

Starting the app with docker-compose up is failing because of version mismatch. #9442

pmverma opened this issue Mar 17, 2019 · 3 comments · Fixed by #9488

Comments

@pmverma
Copy link
Member

pmverma commented Mar 17, 2019

Overview of the issue

An application generated with current master branch (including v5.8.0 and >) will fail to start with docker-compose -f src/main/docker/app.yml up because of version mismatch.

ERROR: Version mismatch: file ./src/main/docker/app.yml specifies version 2.0 but extension file ......../src/main/docker/elasticsearch.yml uses version 2.2

Motivation for or Use Case

Application should start normally with docker-compose.

Reproduce the error
  1. Generate a fresh app with current master
  2. Run ./mvnw package -Pprod verify jib:dockerBuild
  3. Run docker-compose -f src/main/docker/app.yml up
Related issues

PR #9065

Suggest a Fix

If there is no any special requirement to specify the version 2.2 in elasticsearch.yml then I would suggest to use version as 2.
@pvliss should know it better as he has fixed some CI issue in the same commit done for version upgrade.

e0df187#diff-48f10816873d8282f0bc1e95e245580a

JHipster Version(s)
JHipster Version(s)
[email protected] /Users/sierra/github/pmverma/filter
└── [email protected] 

JHipster configuration, a .yo-rc.json file generated in the root folder
.yo-rc.json file
{
  "generator-jhipster": {
    "promptValues": {
      "packageName": "com.mycompany.myapp",
      "nativeLanguage": "en"
    },
    "jhipsterVersion": "5.8.2",
    "applicationType": "monolith",
    "baseName": "filter",
    "packageName": "com.mycompany.myapp",
    "packageFolder": "com/mycompany/myapp",
    "serverPort": "8080",
    "authenticationType": "oauth2",
    "cacheProvider": "no",
    "websocket": false,
    "databaseType": "sql",
    "devDatabaseType": "h2Disk",
    "prodDatabaseType": "postgresql",
    "searchEngine": "elasticsearch",
    "messageBroker": false,
    "serviceDiscoveryType": false,
    "buildTool": "maven",
    "enableSwaggerCodegen": false,
    "clientFramework": "angularX",
    "useSass": true,
    "clientPackageManager": "npm",
    "testFrameworks": [],
    "jhiPrefix": "jhi",
    "entitySuffix": "",
    "dtoSuffix": "DTO",
    "otherModules": [],
    "enableTranslation": true,
    "nativeLanguage": "en",
    "languages": ["en"]
  }
}
JDL for the Entity configuration(s) entityName.json files generated in the .jhipster directory
JDL entity definitions

Environment and Tools

java version "1.8.0_172"
Java(TM) SE Runtime Environment (build 1.8.0_172-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.172-b11, mixed mode)

git version 2.17.2 (Apple Git-113)

node: v10.14.2

npm: 6.7.0

yeoman: 2.0.5

Docker version 18.09.1, build 4c52b90

docker-compose version 1.23.2, build 1110ad01

Browsers and Operating System
  • Checking this box is mandatory (this is just to show you read everything)
@pascalgrimaud
Copy link
Member

pascalgrimaud commented Mar 25, 2019

You're right, we should use same version for all our docker-compose files

@pmverma
Copy link
Member Author

pmverma commented Mar 27, 2019

@pascalgrimaud @pvliss If you do not have any concern with the suggested fix I will do a PR. But again I am not sure for the CI issue which you had earlier. Any thoughts?

@pvliss
Copy link
Contributor

pvliss commented Mar 27, 2019

@pmverma Sorry but I somehow missed this issue. Yes please go ahead. I do not think that switching the version back to 2 will cause any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants