Fix elastic docker compose error for azure ci #9065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do NOT comment out the environment group from elasticsearch.yml - update docker-compose format version to 2.2 - enclosed discovery.type=single-node within double quotes
4 tasks
|
Note, while the CI build still fails, it fails further on at the e2e tests and not when setting up the docker images |
| @@ -5,7 +5,7 @@ source $(dirname $0)/00-init-env.sh | |||
|
|
|||
| cd "$JHI_FOLDER_APP" | |||
| if [ -a src/main/docker/elasticsearch.yml ]; then | |||
| sed -i -e 's/ environment:/ # environment:/1;' src/main/docker/elasticsearch.yml | |||
| #sed -i -e 's/ environment:/ # environment:/1;' src/main/docker/elasticsearch.yml | |||
There was a problem hiding this comment.
as this line will be useless, could you remove it, instead of commenting it ?
- removed commented out line
|
@pvliss @DanielFran : I didn't follow closely what you did with Elasticsearch changes this afternoon, but do you think this PR is needed ? I think yes |
|
Yes, it is needed Otherwise docker-compose will not work for elastic and
test will continue to fail at docker setup, regardless of the elastic
search version used.
Sorry for replying by email but currently no PC available
… @pvliss <https:/pvliss> @DanielFran
<https:/DanielFran> : I didn't follow closely what you did
with Elasticsearch changes this afternoon, but do you think this PR is
needed ? I think yes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9065 (comment)>,
or mute the thread
<https:/notifications/unsubscribe-auth/ACFmqfJP-a0Valcp7Ny7VTTR0Ky1-qQMks5vDhm9gaJpZM4aA2EV>
.
|
|
Don't be sorry for helping JHipster! |
|
@pascalgrimaud Thank you very much and mainly thank you for building such an awesome project and community!!! 👍 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the real problem seemed to be at
test-integration/scripts/20-no-memory-limit-elasticsearch.shwhich was commenting outenvironmentand the fact thatdiscovery.typewas moved out ofcommandsgroup and withinenvironment.Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed