Liquibase - fix floatType for mariadb #9063

pvliss · 2019-01-15T06:49:23Z

Fixes #9061

Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

Fixes jhipster#9061

DanielFran · 2019-01-15T11:30:58Z

Closing/Reopening lo launch tests

DanielFran · 2019-01-15T11:49:42Z

@pvliss Nice catch! Thanks for the PR.

pvliss · 2019-01-15T11:58:24Z

@DanielFran Thanks for merging

BTW, in the case you need some extra help for getting the spring boot 2.1.0 released I would be really happy to help out. Not sure what still needs to be done though

DanielFran · 2019-01-15T12:37:23Z

@pvliss Actually it is only missing the fix for the 2 tests (https://jhipster.visualstudio.com/generator-jhipster/_build/results?buildId=1565):

react-noi18n-es-ws-gradle-session
webflux-mongodb

And a final update for spring-cloud to Greenwich.RELEASE expected Jan 17th (https:/spring-cloud/spring-cloud-release/milestones)

pvliss · 2019-01-15T12:58:00Z

@DanielFran Thanks.

I actually submitted another PR #9065 that fixes the issue with elastic docker not launching but now it fails at the frontend tests. Also the Travis build failed and I do not think it is related to my change. If you could rerun it I would be obliged.

Currently investigating the react-noi18n-es-ws-gradle-session. In my local tests it fails with a ClassNotFoundException for a missing elastic class org/elasticsearch/client/Request:

2019-01-15 14:38:26.123 ERROR 32117 --- [ XNIO-1 task-52] o.z.problem.spring.common.AdviceTrait    : Internal Server Error

org.springframework.web.util.NestedServletException: Handler dispatch failed; nested exception is java.lang.NoClassDefFoundError: org/elasticsearch/client/Request
        at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1053)
        at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:942)
        at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1005)
        at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:897)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
        at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:882)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
        at io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74)
        at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:101)
        at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
        at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
        at org.springframework.boot.actuate.web.trace.servlet.HttpTraceFilter.doFilterInternal(HttpTraceFilter.java:90)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
        at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
        at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:320)
        at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:127)
        at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:91)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:119)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:137)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:111)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.authentication.rememberme.RememberMeAuthenticationFilter.doFilter(RememberMeAuthenticationFilter.java:158)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:170)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:63)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.doFilter(AbstractAuthenticationProcessingFilter.java:200)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:116)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.csrf.CsrfFilter.doFilterInternal(CsrfFilter.java:100)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.web.filter.CorsFilter.doFilterInternal(CorsFilter.java:96)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.header.HeaderWriterFilter.doFilterInternal(HeaderWriterFilter.java:74)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:105)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter.doFilterInternal(WebAsyncManagerIntegrationFilter.java:56)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
        at org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:215)
        at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:178)
        at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:357)
        at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:270)
        at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
        at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
        at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:99)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
        at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
        at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
        at org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:92)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
        at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
        at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
        at org.springframework.web.filter.HiddenHttpMethodFilter.doFilterInternal(HiddenHttpMethodFilter.java:93)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
        at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
        at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
        at org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.filterAndRecordMetrics(WebMvcMetricsFilter.java:117)
        at org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:106)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
        at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
        at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
        at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:200)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
        at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
        at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
        at io.undertow.servlet.handlers.FilterHandler.handleRequest(FilterHandler.java:84)
        at io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62)
        at io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68)
        at io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36)
        at io.undertow.servlet.handlers.security.SSLInformationAssociationHandler.handleRequest(SSLInformationAssociationHandler.java:132)
        at io.undertow.servlet.handlers.security.ServletAuthenticationCallHandler.handleRequest(ServletAuthenticationCallHandler.java:57)
        at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
        at io.undertow.security.handlers.AbstractConfidentialityHandler.handleRequest(AbstractConfidentialityHandler.java:46)
        at io.undertow.servlet.handlers.security.ServletConfidentialityConstraintHandler.handleRequest(ServletConfidentialityConstraintHandler.java:64)
        at io.undertow.security.handlers.AuthenticationMechanismsHandler.handleRequest(AuthenticationMechanismsHandler.java:60)
        at io.undertow.servlet.handlers.security.CachedAuthenticatedSessionHandler.handleRequest(CachedAuthenticatedSessionHandler.java:77)
        at io.undertow.security.handlers.AbstractSecurityContextAssociationHandler.handleRequest(AbstractSecurityContextAssociationHandler.java:43)
        at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
        at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
        at io.undertow.servlet.handlers.SessionRestoringHandler.handleRequest(SessionRestoringHandler.java:119)
        at io.undertow.servlet.handlers.ServletInitialHandler.handleFirstRequest(ServletInitialHandler.java:292)
        at io.undertow.servlet.handlers.ServletInitialHandler.access$100(ServletInitialHandler.java:81)
        at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:138)
        at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:135)
        at io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:48)
        at io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43)
        at io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:272)
        at io.undertow.servlet.handlers.ServletInitialHandler.access$000(ServletInitialHandler.java:81)
        at io.undertow.servlet.handlers.ServletInitialHandler$1.handleRequest(ServletInitialHandler.java:104)
        at io.undertow.server.Connectors.executeRootHandler(Connectors.java:360)
        at io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:830)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NoClassDefFoundError: org/elasticsearch/client/Request
        at org.springframework.boot.actuate.elasticsearch.ElasticsearchRestHealthIndicator.doHealthCheck(ElasticsearchRestHealthIndicator.java:60)
        at org.springframework.boot.actuate.health.AbstractHealthIndicator.health(AbstractHealthIndicator.java:84)
        at org.springframework.boot.actuate.health.CompositeHealthIndicator.health(CompositeHealthIndicator.java:98)
        at org.springframework.boot.actuate.health.HealthEndpoint.health(HealthEndpoint.java:50)
        at org.springframework.boot.actuate.health.HealthEndpointWebExtension.health(HealthEndpointWebExtension.java:54)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.springframework.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:246)
        at org.springframework.boot.actuate.endpoint.invoke.reflect.ReflectiveOperationInvoker.invoke(ReflectiveOperationInvoker.java:76)
        at org.springframework.boot.actuate.endpoint.annotation.AbstractDiscoveredOperation.invoke(AbstractDiscoveredOperation.java:61)
        at org.springframework.boot.actuate.endpoint.web.servlet.AbstractWebMvcEndpointHandlerMapping$ServletWebOperationAdapter.handle(AbstractWebMvcEndpointHandlerMapping.java:294)
        at org.springframework.boot.actuate.endpoint.web.servlet.AbstractWebMvcEndpointHandlerMapping$OperationHandler.handle(AbstractWebMvcEndpointHandlerMapping.java:355)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:189)
        at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:138)
        at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:102)
        at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:895)
        at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:800)
        at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:87)
        at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1038)
        ... 105 common frames omitted
Caused by: java.lang.ClassNotFoundException: org.elasticsearch.client.Request
        at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 130 common frames omitted

It seems that it has been introduced in elastic 6.4.0(first commit link), hence upgrading jhipster to 6.4.3 to also match the one used by spring boot will probably solve this issue as well. Will create a PR for that too.

DanielFran · 2019-01-15T13:15:18Z

@pvliss We needed to downgrade to Elasticsearch 6.2.2 (instead of 6.4.3) because spring-data-elasticsearch Lovelace-SR4 is targetting 6.2.2

pvliss · 2019-01-15T13:31:08Z

Oh, I see. Weird though that this is somehow requested. Will investigate further, thanks

pvliss · 2019-01-15T13:45:40Z

@dancancro So it seems there are currently currently 2 clients available as explained in the docs and the REST client uses 6.4.x. Would you like me to investigate switching temporarily to the Jest client or is this something you do not want or tried already?

pvliss · 2019-01-15T13:50:10Z

Hmmm. I now see that a Jest client is already used.

DanielFran · 2019-01-15T13:53:48Z

@pvliss I downgrade docker elasticsearch version, let see if it fix the current issue!

DanielFran · 2019-01-15T14:15:57Z

We need to review the docker-compose file and compare with https://www.elastic.co/guide/en/elasticsearch/reference/6.2/docker.html

Note: port is 9300 due to jest

pvliss · 2019-01-15T14:21:26Z

Regarding the webflux-mongodb, I have found the error in UserService.java.ejs but this seems to have already been fixed at master: 84c9b06.

Judging from the title it could also fix the frontend test failures for react-noi18n-es-ws-gradle-session as well.

Can you try merging this to the spring-boot_2.1.0 as well?

pvliss · 2019-01-15T14:25:34Z

We need to review the docker-compose file and compare with https://www.elastic.co/guide/en/elasticsearch/reference/6.2/docker.html

Note: port is 9300 due to jest

I have already submitted PR #9065 that fixes the issue with elastic docker. if not merged then azure CI build will continue to fail at that point

pvliss · 2019-01-15T14:48:01Z

@DanielFran As I see the webflux-mongodb is server side only I will submit a PR that fixes this compilation problem as 84c9b06 seems to be huge and maybe better to handle when the branch is merged back to master. What do you think?

pvliss · 2019-01-15T15:47:37Z

@DanielFran It seems that image at least for generator-jhipster/generators/server/templates/src/main/docker/elasticsearch.yml.ejs should be changed to: docker.elastic.co/elasticsearch/elasticsearch:6.2.4

DanielFran · 2019-01-15T15:52:00Z

@pvliss This is what I did in #9067 few minutes ago.

About mongodb, I believe it is due to the merge from master branch that @jdubois did 13 days ago....

pvliss · 2019-01-15T16:35:41Z

@pvliss This is what I did in #9067 few minutes ago.

Yes, but this is failing the build as the 6.2.4 is not available from what I understand at docker hub.
It needs to change to: docker.elastic.co/elasticsearch/elasticsearch:6.2.4.
I have also added a comment to your commit: bd49df7#r247967760

pvliss · 2019-01-15T20:23:30Z

@DanielFran With the PR #9074 everything has turned green for both Travis and Azure. So once #9074 is also merged then I think that spring_boot_2.1.0 is ready?

jdubois · 2019-01-15T20:54:19Z

Thank you so much @pvliss !!

pvliss · 2019-01-15T21:07:07Z

@jdubois Again thank you for creating such an awesome project and community!!! Glad to be able to help!!!

Liquibase - fix floatType for mariadb

f040010

Fixes jhipster#9061

pvliss mentioned this pull request Jan 15, 2019

upgrade to latest maven wrapper and maven to 3.6.0 jhipster/jhipster#155

Closed

DanielFran closed this Jan 15, 2019

DanielFran reopened this Jan 15, 2019

DanielFran merged commit 0d07a42 into jhipster:spring-boot_2.1.0 Jan 15, 2019

pvliss deleted the gh-9061 branch January 15, 2019 11:55

DanielFran mentioned this pull request Jan 15, 2019

Upgrade to spring-boot 2.1.x #8683

Closed

29 tasks

pvliss mentioned this pull request Jan 15, 2019

fix UserService.java.ejs for reactive #9074

Merged

4 tasks

jdubois added this to the 5.8.0 milestone Jan 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Liquibase - fix floatType for mariadb #9063

Liquibase - fix floatType for mariadb #9063

pvliss commented Jan 15, 2019

DanielFran commented Jan 15, 2019

DanielFran commented Jan 15, 2019

pvliss commented Jan 15, 2019

DanielFran commented Jan 15, 2019

pvliss commented Jan 15, 2019

DanielFran commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

DanielFran commented Jan 15, 2019

DanielFran commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

DanielFran commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

jdubois commented Jan 15, 2019

pvliss commented Jan 15, 2019

Liquibase - fix floatType for mariadb #9063

Liquibase - fix floatType for mariadb #9063

Conversation

pvliss commented Jan 15, 2019

DanielFran commented Jan 15, 2019

DanielFran commented Jan 15, 2019

pvliss commented Jan 15, 2019

DanielFran commented Jan 15, 2019

pvliss commented Jan 15, 2019

DanielFran commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

DanielFran commented Jan 15, 2019

DanielFran commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

DanielFran commented Jan 15, 2019

pvliss commented Jan 15, 2019

pvliss commented Jan 15, 2019

jdubois commented Jan 15, 2019

pvliss commented Jan 15, 2019