This repository has been archived by the owner on May 7, 2022. It is now read-only.
Fix no_implicit_prelude doc issue #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajbouw
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no_implicit_preludeis handy if you want to know exactly what you are using in your library, allowing you to slim it down later as you typically have all your new prelude imports altogether. Cuts down on code as well, cleaning things up drastically.The issue is that
#![no_implicit_prelude]at lib level used to work fine. Then Serde support was added and it wouldn't build Serde since it too usesno_implicit_prelude. There was a work around though which worked. Problem is, now that workaround is broken. While the project will build fine, this is problematic for documentation.The new workaround that I have found is to not make it lib level and instead include it in each of the modules which is a bit of a pain in the butt but it is the only thing that I can get to work for now. There is work being done that will turn the issue into a warning and not a panic though.
See: rust-lang/rust#80372