Don't panic when an external crate can't be resolved #80372
Conversation
jyn514
added
A-intra-doc-links
This comment has been minimized.
This comment has been minimized.
This isn't actually a bug, it can occur when rustdoc tries to resolve a crate that isn't used in the main code.
|
This is a very important fix. I am unable to generate documentation for many of my projects (notably when using |
|
@jamadazi hmm, I'm surprised to hear that - this should always be fixable by just not passing the |
|
I am very much interested in generating combined documentation for all my dependencies, together with the crates in the current workspace. That is how I typically use rustdoc -- to give me full, complete, offline documentation for everything relevant to my project (including the whole dependency tree). It makes it very easy to access whatever docs I want, from a single place, offline. EDIT: also, this is the default behaviour of |
jyn514
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 7edd181 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 7 pull requests Successful merges: - rust-lang#79675 (Make sure rust-call errors occur correctly for traits) - rust-lang#80372 (Don't panic when an external crate can't be resolved) - rust-lang#80761 (handle generic trait methods in coverage-report tests) - rust-lang#80785 (rustc_ast_pretty: Remove `PrintState::insert_extra_parens`) - rust-lang#80791 (Fix type name in doc example for Iter and IterMut) - rust-lang#80794 (Use Option::map_or instead of `.map(..).unwrap_or(..)`) - rust-lang#80799 (Get rid of custom pretty-printing in rustdoc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This isn't actually a bug, it can occur when rustdoc tries to resolve a
crate that isn't used in the main code.
Fixes #72381.
r? @kinnison if you have time, otherwise @Manishearth