Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test network policies in more situations #52

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jun 12, 2022

I observed test failures in z2jh using main of this action, but this action had its test pass correctly. The reason was that we didn't test the netpol tests together with the actions docker-enabled: true setting, with it, netpol enforcement fails.

This PR makes our test suite capture such failures correctly.

@consideRatio consideRatio force-pushed the pr/test-k8s-networkpolicy-with-docker branch from b5d9750 to 2478585 Compare June 12, 2022 23:45
@consideRatio
Copy link
Member Author

I'll merge this to start working on the resolution to make our test suite green again.

@consideRatio consideRatio merged commit cadd73f into jupyterhub:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant