ci: add github-token permissions for CodeQL workflow #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
This was referenced May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first time i see the CodeQL workflow fail if I recall correctly. I get notifications as I'm considered the "actor" of the scheduled CI job when it triggers - because i changed the file most recently.
As the JupyterHub org made the secrets.GITHUB_TOKEN readonly, we introduced failures like this one. By setting the permissions explicitly, we get things functional again.
Note that the permissions I set in this PR were not guessed, but I saw recent changes in the CodeQL repository and mirror those: github/codeql-action@e305db8