Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binderhub: 0.2.0-n557.h46ddaac...0.2.0-n562.h0b4462c #1900

Merged
merged 1 commit into from
May 7, 2021
Merged

binderhub: 0.2.0-n557.h46ddaac...0.2.0-n562.h0b4462c #1900

merged 1 commit into from
May 7, 2021

Conversation

henchbot
Copy link
Contributor

@henchbot henchbot commented May 3, 2021

This is a binderhub version bump. See the link below for a diff of new changes:

jupyterhub/binderhub@46ddaac...0b4462c

Associated PRs:

  • build_docker_config added, enables augmentation of the build pod's docker config #1255
  • ci: add github-token permissions for CodeQL workflow #1292
  • A description is a bit paraphrased #1290

@betatim
Copy link
Member

betatim commented May 3, 2021

Please don't merge this for the moment. It looks like this breaks build pods on mybinder.org

@manics manics marked this pull request as draft May 3, 2021 15:46
@betatim betatim marked this pull request as ready for review May 7, 2021 14:01
@betatim
Copy link
Member

betatim commented May 7, 2021

After discussion in jupyterhub/binderhub#1293 going to try this again and see if the binderhub pods restart and become ready or not.

@betatim betatim merged commit 322eae1 into jupyterhub:master May 7, 2021
@betatim
Copy link
Member

betatim commented May 7, 2021

Two new bhub pods were created. One is running and one is "containercreating".

For one of the newly started binderhub pod's events:

  Type     Reason       Age               From                                         Message
  ----     ------       ----              ----                                         -------
  Normal   Scheduled    71s               default-scheduler                            Successfully assigned prod/binder-85f4d9c68d-9n4hd to gke-prod-core-202009-9045565e-dm8m
  Warning  FailedMount  7s (x8 over 71s)  kubelet, gke-prod-core-202009-9045565e-dm8m  MountVolume.SetUp failed for volume "docker-secret" : secret "binder-push-secret" not found

This is the other bhub pod:

  Type     Reason       Age                  From                                         Message
  ----     ------       ----                 ----                                         -------
  Normal   Scheduled    5m2s                 default-scheduler                            Successfully assigned prod/binder-85f4d9c68d-9n4hd to gke-prod-core-202009-9045565e-dm8m
  Warning  FailedMount  2m59s                kubelet, gke-prod-core-202009-9045565e-dm8m  Unable to attach or mount volumes: unmounted volumes=[docker-secret], unattached volumes=[config secret-config docker-secret binderhub-token-5w5dr]: timed out waiting for the condition
  Warning  FailedMount  52s (x10 over 5m2s)  kubelet, gke-prod-core-202009-9045565e-dm8m  MountVolume.SetUp failed for volume "docker-secret" : secret "binder-push-secret" not found
  Warning  FailedMount  43s                  kubelet, gke-prod-core-202009-9045565e-dm8m  Unable to attach or mount volumes: unmounted volumes=[docker-secret], unattached volumes=[docker-secret binderhub-token-5w5dr config secret-config]: timed out waiting for the condition

These are the secrets that exist

$ kubectl get secrets| grep binder     
binder-build-docker-config                  Opaque                                1      2m47s
binder-secret                               Opaque                                2      228d
binderhub-token-5w5dr                       kubernetes.io/service-account-token   3      228d
kubelego-tls-binder-prod                    kubernetes.io/tls                     3      228d

@betatim
Copy link
Member

betatim commented May 7, 2021

Just some random notes, probably don't make sense.


Interestingly enough the old bhub pod also has the following events:

  Type     Reason       Age                   From                                         Message
  ----     ------       ----                  ----                                         -------
  Warning  FailedMount  117s (x10 over 6m7s)  kubelet, gke-prod-core-202009-9045565e-dm8m  MountVolume.SetUp failed for volume "docker-secret" : secret "binder-push-secret" not found

So maybe the fact that this is missing/broken isn't the cause for the pods failing. Though worth investigating why this is being mounted but not available.

running jupyterhub/k8s-binderhub:0.2.0-n562.h0b4462c
creating jupyterhub/k8s-binderhub:0.2.0-n562.h0b4462c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants