properly fixes sort issue: #131

kanaverse · Jul 23, 2022 · e204cd8 · e204cd8
1 parent 8c94afe
commit e204cd8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/App.js b/src/App.js
@@ -209,7 +209,7 @@ const App = () => {
 
  if (customSelection !== null && Object.keys(customSelection).length > 0 && !initLoadState) {
  let csLen = `cs${Object.keys(customSelection).length}`;
- var cs = customSelection[csLen].sort((a, b) => { return a-b });
+ var cs = customSelection[csLen];
  scranWorker.postMessage({
  "type": "computeCustomMarkers",
  "payload": {

diff --git a/src/components/Plots/DimPlot.js b/src/components/Plots/DimPlot.js
@@ -511,7 +511,7 @@ const DimPlot = (props) => {
 
  let cid = Object.keys(props?.customSelection).length;
  let tmpSelection = { ...props?.customSelection };
- tmpSelection[`cs${cid + 1}`] = props?.selectedPoints?.sort(); // AL: is this safe to do? Or should we copy first?
+ tmpSelection[`cs${cid + 1}`] = props?.selectedPoints?.sort((a, b) => { return a-b });
  props?.setCustomSelection(tmpSelection);
 
  props?.setSelectedPoints(null);