Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I don't think the custom selection indices are sorted #131

Closed
LTLA opened this issue Jul 9, 2022 · 2 comments
Closed

I don't think the custom selection indices are sorted #131

LTLA opened this issue Jul 9, 2022 · 2 comments

Comments

@LTLA
Copy link
Collaborator

LTLA commented Jul 9, 2022

Screenshot from 2022-07-09 02-03-39

From printing the payload.selection received by the worker on a computeCustomMarkers signal.

Safest to sort them on the bakana side, provided that this has no ill effects on the kana side.
@LTLA
Copy link
Collaborator Author

LTLA commented Jul 9, 2022 •
edited
Loading

Latest master version of bakana will now throw if unsorted, duplicate or out-of-range indices are passed in.

This means that any sorting should be done on the UI side. Best to do so anyway for consistent treatment in both UI and worker.

@LTLA LTLA mentioned this issue Jul 9, 2022
Merged
LTLA added a commit that referenced this issue Jul 14, 2022
@LTLA
Make sure custom selection indices are sorted, closes #131.
3a710f7
@jkanche
Copy link
Collaborator

jkanche commented Jul 23, 2022

#133 fixes this

@jkanche jkanche mentioned this issue Jul 23, 2022
Merged
jkanche added a commit that referenced this issue Jul 23, 2022
@jkanche
properly fixes sort issue: #131
e204cd8
@jkanche jkanche closed this as completed Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkanche @LTLA