Enable testing on Python 3.12 & PyPy 3.9/3.10 #754
Conversation
Copy the `debuglevel` and `_http_vsn` attributes from base connection class into response classes, in order to fix compatibility with Python 3.12. For reasons I don't comprehend, these end up being called on the class rather than instance, so regular proxying logic does not work. Fixes kevin1024#707
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #754 +/- ##
==========================================
- Coverage 90.46% 90.37% -0.09%
==========================================
Files 27 27
Lines 1815 1819 +4
Branches 337 337
==========================================
+ Hits 1642 1644 +2
- Misses 129 131 +2
Partials 44 44
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Disable the C extension in aiohttp that's incompatible with Python 3.12 as of 3.8.5, in order to make it possible to install it (in pure Python version) for testing.
|
The problem with aiohttp is that the current release's sdist has C files generated using old version of Cython. I've added a tox change that disables the C extension when building for 3.12, making it possible to install pure Python version of aiohttp for testing. |
|
I think the remaining test failures are (preexisting) flakiness and not related to my changes. |
|
LGTM. |
|
@jairhenrique sorry, I lack bandwidth for this, I need to cut down my time on VCR.py for now. |
|
Thank you! |
As requested in #707 (comment).
I've also noticed that PyPy3.9 and 3.10 were missing, so added them as well.