Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish up on Python 3.12 support #775

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Finish up on Python 3.12 support #775

merged 1 commit into from
Dec 10, 2023

Conversation

hartwork
Copy link
Collaborator

@hartwork hartwork commented Oct 6, 2023

Follow-up to #754

@hartwork hartwork marked this pull request as draft October 6, 2023 15:12
xnetcat added a commit to spotDL/spotify-downloader that referenced this pull request Dec 1, 2023
@jairhenrique
Copy link
Collaborator

@hartwork can you rebase with master!?

@hartwork
Copy link
Collaborator Author

hartwork commented Dec 8, 2023

@hartwork can you rebase with master!?

@jairhenrique sure, but it had little chance of working (with regard to red CI) last time, hence the draft. Rebased and pushed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (604c0be) 90.10% compared to head (954a100) 90.10%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #775   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files          27       27           
  Lines        1809     1809           
  Branches      335      335           
=======================================
  Hits         1630     1630           
  Misses        134      134           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hartwork
Copy link
Collaborator Author

hartwork commented Dec 8, 2023

@jairhenrique I have re-run the pypy3.10 CI 10 times now without a single success. I believe it's time to declare that support broken and drop it in a dedicated pull request, coming up in a minute. The errors were:

a) with -m 'not online' (most of the time)

[..]
E           urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))
[..]
=========================== short test summary info ============================
FAILED tests/integration/test_urllib3.py::test_post[https] - urllib3.exceptio...
=========== 1 failed, 249 passed, 9 skipped, 14 deselected in 22.59s ===========
[..]

b) with -m online (rarely)

[..]
E           requests.exceptions.ConnectionError: HTTPSConnectionPool(host='api.flickr.com', port=443): Max retries exceeded with url: /services/upload (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x00007fc8b1f54870>: Failed to establish a new connection: [Errno 101] Network is unreachable'))
[..]
=========================== short test summary info ============================
FAILED tests/integration/test_wild.py::test_flickr_should_respond_with_200 - ...[..]
===== 1 failed, 15 passed, 5 skipped, 293 deselected in 144.59s (0:02:24) ======
[..]

@hartwork hartwork merged commit 8a8d46f into master Dec 10, 2023
9 checks passed
@hartwork hartwork deleted the python-3-12 branch December 10, 2023 22:50
@hartwork
Copy link
Collaborator Author

@jairhenrique now that this is merged, I'll write an issue recommending a new release to unblock users' upgrade to Python 3.12. Will take a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants