Unique secret names #3134
Merged
Unique secret names #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## main #3134 +/- ##
============================================
- Coverage 63.51% 63.41% -0.11%
+ Complexity 763 758 -5
============================================
Files 169 167 -2
Lines 11859 11356 -503
Branches 246 233 -13
============================================
- Hits 7532 7201 -331
+ Misses 3755 3628 -127
+ Partials 572 527 -45
Flags with carried forward coverage won't be shown. Click here to find out more. |
5 tasks
knative-prow bot
pushed a commit
to knative/eventing
that referenced
this pull request
Jul 17, 2023
…7002) Supports knative-extensions/eventing-kafka-broker#3133 which is being implemented in knative-extensions/eventing-kafka-broker#3134 and requires these changes in knative eventing. <!-- Please include the 'why' behind your changes if no issue exists --> ## Proposed Changes <!-- Please categorize your changes: - 🎁 Add new feature - 🐛 Fix bug - 🧹 Update or clean up current behavior - 🗑️ Remove feature or internal logic --> - - - ### Pre-review Checklist <!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. --> - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** <!-- 📄 If this change has user-visible impact, write a release note in the block below. Include the string "action required" if additional action is required of users switching to the new release, for example in case of a breaking change. Write as if you are speaking to users, not other Knative contributors. If this change has no user-visible impact, no release note is needed. --> ```release-note ``` **Docs** <!-- 📖 If this change has user-visible impact, link to an issue or PR in https:/knative/docs. -->
mgencur
force-pushed
the
unique_secret_names
branch
from
53e619c
to
0aea67a
Compare
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
|
/test channel-integration-tests-sasl-plain |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/test channel-integration-tests-sasl-ssl |
knative-prow
bot
merged commit 00f0dab
into
knative-extensions:main
18 of 22 checks passed
Rahul-Kumar-prog
pushed a commit
to Rahul-Kumar-prog/eventing-kafka-broker
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3133
Proposed Changes
Release Note
Docs