Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function CopySecretWithName for creating secrets with specific name #7002

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Function CopySecretWithName for creating secrets with specific name #7002

merged 1 commit into from
Jul 17, 2023

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Jun 5, 2023

Supports knative-extensions/eventing-kafka-broker#3133 which is being implemented in knative-extensions/eventing-kafka-broker#3134 and requires these changes in knative eventing.

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2023
@knative-prow knative-prow bot requested review from lberk and pierDipi June 5, 2023 12:27
@mgencur
Copy link
Contributor Author

mgencur commented Jun 5, 2023

/retest-required

@mgencur mgencur changed the title [WIP] Function CopySecretWithName for creating secrets with specific name Function CopySecretWithName for creating secrets with specific name Jun 5, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2023
@mgencur
Copy link
Contributor Author

mgencur commented Jun 5, 2023

/retest-required

@mgencur
Copy link
Contributor Author

mgencur commented Jun 6, 2023

/test reconciler-tests_eventing_main

matzew
matzew approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@matzew
Copy link
Member

matzew commented Jun 13, 2023

/retest

@mgencur
Copy link
Contributor Author

mgencur commented Jun 14, 2023

/retest-required

@mgencur
Copy link
Contributor Author

mgencur commented Jul 13, 2023

/retest

@mgencur
Copy link
Contributor Author

mgencur commented Jul 13, 2023

/retest-required

@mgencur
Copy link
Contributor Author

mgencur commented Jul 13, 2023

/cherry-pick release-1.9

@knative-prow-robot
Copy link
Contributor

@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgencur
Copy link
Contributor Author

mgencur commented Jul 13, 2023

/cherry-pick release-1.10

@knative-prow-robot
Copy link
Contributor

@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgencur
Copy link
Contributor Author

mgencur commented Jul 13, 2023

/test upgrade-tests_eventing_main

@mgencur mgencur mentioned this pull request Jul 13, 2023
Closed
5 tasks
@mgencur
Copy link
Contributor Author

mgencur commented Jul 13, 2023

The upgrade test failure is not related to this PR. It also fails on #7090

@mgencur
Copy link
Contributor Author

mgencur commented Jul 14, 2023

/test upgrade-tests_eventing_main

2 similar comments
@mgencur
Copy link
Contributor Author

mgencur commented Jul 17, 2023

/test upgrade-tests_eventing_main

@mgencur
Copy link
Contributor Author

mgencur commented Jul 17, 2023

/test upgrade-tests_eventing_main

@knative-prow knative-prow bot merged commit de75496 into knative:main Jul 17, 2023
@knative-prow-robot
Copy link
Contributor

@mgencur: #7002 failed to apply on top of branch "release-1.9":

Applying: Function CopySecretWithName for creating secrets with specific name
Using index info to reconstruct a base tree...
M	pkg/utils/secret.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/utils/secret.go
CONFLICT (content): Merge conflict in pkg/utils/secret.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Function CopySecretWithName for creating secrets with specific name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Jul 17, 2023
Merged
@knative-prow-robot
Copy link
Contributor

@mgencur: new pull request created: #7094

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgencur mgencur mentioned this pull request Jul 18, 2023
Closed
5 tasks
knative-prow bot pushed a commit that referenced this pull request Jul 20, 2023
@knative-prow-robot @mgencur
[release-1.10] Function CopySecretWithName for creating secrets with …
76982bf 
…specific name (#7094)

This is an automated cherry-pick of #7002

```release-note

```

Co-authored-by: Martin Gencur <[email protected]>
ReToCode pushed a commit to ReToCode/eventing that referenced this pull request Aug 3, 2023
@knative-prow-robot @mgencur @ReToCode
[release-1.10] Function CopySecretWithName for creating secrets with …
7ae0e3a 
…specific name (knative#7094)

This is an automated cherry-pick of knative#7002

```release-note

```

Co-authored-by: Martin Gencur <[email protected]>
openshift-merge-robot pushed a commit to openshift-knative/eventing that referenced this pull request Aug 4, 2023
@ReToCode @knative-prow-robot @mgencur
[release-1.10] Function CopySecretWithName for creating secrets with …
45e12e1 
…specific name (knative#7094) (#302)

This is an automated cherry-pick of knative#7002

```release-note

```

Co-authored-by: Knative Prow Robot <[email protected]>
Co-authored-by: Martin Gencur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@lberk lberk Awaiting requested review from lberk

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgencur @matzew @knative-prow-robot