HTTP Endpoint for KOURIER_EXTAUTHZ_HOST

[sidharthramesh]

I see in the e2e tests for external authz that a gRPC service is supported. Any idea this will support a HTTP service?

I'd like to use ORY Oathkeeper as the external authenticator and it only exposes an HTTP endpoint for now.

[nak3]

/good-first-issue

We did not have the plan as nobody requested the feature. But I think it makes sense and complicated change is not necessary.
It just needs to add an option and switch the http option here - https:/knative-sandbox/net-kourier/blob/37d366313782ca3ebf7b40166c278610fac72205/pkg/config/ext_authz.go#L97-L103

PR is welcome 🙏

[knative-prow-robot]

@nak3:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

We did not have the plan as nobody requested the feature. But I think it makes sense and complicated change is not necessary.
It just needs to add an option and switch the http option here - https:/knative-sandbox/net-kourier/blob/37d366313782ca3ebf7b40166c278610fac72205/pkg/config/ext_authz.go#L97-L103

PR is welcome 🙏

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sidharthramesh]

Thank you @nak3. I'll try to understand the code.

According to the Envoy docs either grpc_service (config.core.v3.GrpcService) or http_service (extensions.filters.http.ext_authz.v3.HttpService) should be set.

So I'm assuming there's also going to be some changes here?
https:/knative-sandbox/net-kourier/blob/37d366313782ca3ebf7b40166c278610fac72205/pkg/config/ext_authz.go#L141-L155

I'm very new to this, and barely getting around Knative, Kourier and GoLang. So forgive me if I'm not very helpful.

[nak3]

Yes, I think you are right. Thank you!