Ext auth service : add http/https protocol

[norbjd]

Changes

🎁 Add http/https protocol for ext auth service

/kind enhancement

Fixes #754

Release Note

An http/https service can now be used as ext auth service

Docs

No docs.

[knative-prow-robot]

Hi @norbjd. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #786 (c59e34d) into main (a7937d6) will increase coverage by 9.33%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
+ Coverage   73.16%   82.49%   +9.33%     
==========================================
  Files          18       18              
  Lines         749      777      +28     
==========================================
+ Hits          548      641      +93     
+ Misses        165       99      -66     
- Partials       36       37       +1     

Impacted Files	Coverage Δ
pkg/config/ext_authz.go	83.33% <90.00%> (+81.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7937d6...c59e34d. Read the comment docs.

[norbjd]

Hello 👋

If this feature is ok to add to Kourier, I will of course write tests to increase code coverage (or at least, to not decrease it 😁).

[nak3]

/ok-to-test

Thank you so much @norbjd
Let's try to add this fix into v1.4 release as v.1.3 will be released tomorrow (8/Mar).

[nak3]

Some refactoring comments but LGM overall. We would like to have tests as @norbjd already mentioned 👍

[norbjd]

Hello @nak3 ! Thanks for your review.

I have refactored the code according to your comments, and also added some unit tests and e2e tests.

Also, I don't know if I should test https protocol, since it's the same as http.

[nak3]

Thank you so much @norbjd ! LGTM, I just left some comments for the style again.

[nak3]

Also, I don't know if I should test https protocol, since it's the same as http.

I think current test cases without https are fine. Thank you!

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-net-kourier-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/config/ext_authz.go	9.5%	55.9%	46.4

[nak3]

/lgtm
/approve

Thank you @norbjd !

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, norbjd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nak3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment