Fix clippy lints #324
Fix clippy lints #324
Conversation
|
Feel free to cherry-pick commits, if some changes are not desired. Clippy was added to the CI to confirm the correct alliance of the suggested fixes. I'm thinking about adding a rustfmt ci job as well? The code base is mostly consistent with the default rustfmt style, but not everywhere. I'm not sure about the UI tests failures. Is this directly related to my changes or where these introduced because of the 1.49 rustc release? |
| components: clippy | ||
| - uses: actions-rs/clippy-check@v1 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
(why) is this needed? (also, I don't think we have set any secrets for this repo.)
There was a problem hiding this comment.
This is what the clippy-check action requires and suggest in its default configuration.
This step even fails, when this toke key is not set. I guess, it's about a hidden token generated by github, which has to be passed to clippy-check, so that it can annotate PRs with clippy warnings? TBH, I haven't looked much further. The correct answer can be probably found at the clippy-check repository.
| @@ -2,4 +2,4 @@ error: `#[panic_handler]` attribute cannot be used together with `#[export_name] | |||
| --> $DIR/panic-handler-export-name.rs:5:1 | |||
| | | |||
| 5 | #[export_name = "hello"] | |||
| | ^^^^^^^^^^^^^^^^^^^^^^^^ | |||
There was a problem hiding this comment.
you can undo these changes. I've fixed the UI issues in PR #325
#[warn(clippy::match_like_matches_macro)]
#[warn(clippy::single_char_add_str)]
Use of `unwrap_or` followed by a call to `new`
#[warn(clippy::ptr_arg)]
#[warn(clippy::single_char_pattern)]
#[warn(clippy::len_zero)]
#[warn(clippy::needless_lifetimes)]
#[warn(clippy::unnecessary_lazy_evaluations)]
#[warn(clippy::redundant_field_names)]
#[warn(clippy::collapsible_if)]
#[warn(clippy::needless_lifetimes)]
|
I've added rustfmt and rebased onto main, so that the UI tests are running again. I stopped at Same goes for the |
#[warn(clippy::declare_interior_mutable_const)]
329: document safety of implementation detail functions r=japaric a=japaric fixes some clippy lints should unblock #324 Co-authored-by: Jorge Aparicio <[email protected]>
|
bors r+ |
|
Build succeeded: |
No description provided.