Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update UI tests #325

Merged
merged 4 commits into from
Jan 4, 2021
Merged

update UI tests #325

merged 4 commits into from
Jan 4, 2021

Conversation

japaric
Copy link
Member

@japaric japaric commented Jan 4, 2021

span info has changed in the last rust update (stable channel)

span info has changed in the last rust update (stable channel)
@japaric
Copy link
Member Author

japaric commented Jan 4, 2021

bors r+

bors bot added a commit that referenced this pull request Jan 4, 2021
325: update UI tests r=japaric a=japaric

span info has changed in the last rust update (stable channel)

Co-authored-by: Jorge Aparicio <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 4, 2021

Build failed:

@japaric
Copy link
Member Author

japaric commented Jan 4, 2021

bors r+

bors bot added a commit that referenced this pull request Jan 4, 2021
325: update UI tests r=japaric a=japaric

span info has changed in the last rust update (stable channel)

Co-authored-by: Jorge Aparicio <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 4, 2021

Build failed:

@japaric
Copy link
Member Author

japaric commented Jan 4, 2021

Build failed:
ci

but all test jobs passed ...

bors retry

bors bot added a commit that referenced this pull request Jan 4, 2021
325: update UI tests r=japaric a=japaric

span info has changed in the last rust update (stable channel)

Co-authored-by: Jorge Aparicio <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 4, 2021

Build failed:

bors' semantics have changed: skipped checks are now considered failures
the result is that when all build jobs pass the ci-failure reports a "ci" check as skipped
(expected behavior) but that is now considered a failure by bors

removing the ci-failure conditional should fix the issue
if any build job fails then ci-success will report "ci" as skipped, which bors will consider as a
failure
@japaric
Copy link
Member Author

japaric commented Jan 4, 2021

bors r+

@japaric japaric mentioned this pull request Jan 4, 2021
@bors
Copy link
Contributor

bors bot commented Jan 4, 2021

Build succeeded:

@bors bors bot merged commit a69b3db into main Jan 4, 2021
@bors bors bot deleted the fix-ci branch January 4, 2021 13:30
@japaric japaric mentioned this pull request Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant