Fix -P with passing ko:// through. #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out I broke this. Thanks to @bobcatfish for reporting the issue. With this change: ``` ko resolve -Pf cmd/ko/test/test.yaml > /dev/null 2020/05/04 08:44:35 Using base gcr.io/distroless/static:nonroot for github.com/google/ko/cmd/ko/test 2020/05/04 08:44:36 Building github.com/google/ko/cmd/ko/test 2020/05/04 08:44:37 Publishing gcr.io/mattmoor-knative/github.com/google/ko/cmd/ko/test:latest 2020/05/04 08:44:39 Published gcr.io/mattmoor-knative/github.com/google/ko/cmd/ko/test@sha256:ee655510172b429dbce619fc69677621d71cb824cbbf2a21746d700127257ec4 ``` I can cut v0.5.1 once this lands.
imjasonh
approved these changes
May 4, 2020
|
Thanks for the quick fix @mattmoor !! 🏎️ |
bobcatfish
added a commit
to bobcatfish/plumbing
that referenced
this pull request
May 4, 2020
We were installing ko from master @ head which means if any bugs are introduced, we'll hit them. A bug was introduced in how -P works which was fixed in ko-build/ko#163 by @mattmoor almost immediately so let's pin to the version with that fix so we can deal with changes to ko at our leisure vs. surfacing ko errors in our CI. Fixes tektoncd#370
1 task
bobcatfish
added a commit
to bobcatfish/plumbing
that referenced
this pull request
May 5, 2020
We were installing ko from master @ head which means if any bugs are introduced, we'll hit them. A bug was introduced in how -P works which was fixed in ko-build/ko#163 by @mattmoor almost immediately so let's pin to the version with that fix so we can deal with changes to ko at our leisure vs. surfacing ko errors in our CI. Fixes tektoncd#370
bobcatfish
added a commit
to bobcatfish/plumbing
that referenced
this pull request
May 5, 2020
We were installing ko from master @ head which means if any bugs are introduced, we'll hit them. A bug was introduced in how -P works which was fixed in ko-build/ko#163 by @mattmoor almost immediately so let's pin to the version with that fix so we can deal with changes to ko at our leisure vs surfacing ko errors in our CI. Fixes tektoncd#370
tekton-robot
pushed a commit
to tektoncd/plumbing
that referenced
this pull request
May 5, 2020
We were installing ko from master @ head which means if any bugs are introduced, we'll hit them. A bug was introduced in how -P works which was fixed in ko-build/ko#163 by @mattmoor almost immediately so let's pin to the version with that fix so we can deal with changes to ko at our leisure vs surfacing ko errors in our CI. Fixes #370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I broke this. Thanks to @bobcatfish for reporting the issue.
With this change:
I can cut v0.5.1 once this lands.