Pin verison of ko we install 📌 #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XS
|
/test plumbing-yamllint |
|
@bobcatfish I think you need to rebase against latest upstream master to remove the error 👼 |
ghost
approved these changes
May 5, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
plumbing-ko-build seems to have this failure: |
|
Not sure how to re-trigger the check, maybe thats a WIP ( @afrittoli lemme know if there's a way ) I'll just force push a commit message change to trigger again |
We were installing ko from master @ head which means if any bugs are introduced, we'll hit them. A bug was introduced in how -P works which was fixed in ko-build/ko#163 by @mattmoor almost immediately so let's pin to the version with that fix so we can deal with changes to ko at our leisure vs surfacing ko errors in our CI. Fixes tektoncd#370
|
/lgtm
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We were installing ko from master @ head which means if any bugs are
introduced, we'll hit them. A bug was introduced in how -P works which
was fixed in ko-build/ko#163 by @mattmoor almost
immediately so let's pin to the version with that fix so we can deal
with changes to ko at our leisure vs. surfacing ko errors in our CI.
Fixes #370
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.