Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid escape sequence \. in kokkos_functions.cmake #1661

Closed
MalachiTimothyPhillips opened this issue Jun 6, 2018 · 2 comments
Closed

Invalid escape sequence \. in kokkos_functions.cmake #1661

MalachiTimothyPhillips opened this issue Jun 6, 2018 · 2 comments
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@MalachiTimothyPhillips
Copy link

MalachiTimothyPhillips commented Jun 6, 2018

string(REGEX MATCH "[0-9]+\.[0-9]+\.[0-9]+$"

All:

I was building Trilinos using an ancient version of Cmake (2.8.12.2) and ran into this particular error:

CMake Error at packages/kokkos/cmake/kokkos_functions.cmake:50 (string):
Syntax error in cmake code at

/packages/Trilinos/packages/kokkos/cmake/kokkos_functions.cmake:50

when parsing string

[0-9]+\.[0-9]+\.[0-9]+$

Invalid escape sequence .

I was able to fix this issue by changing the REGEX to [0-9]+\\.[0-9]+\\.[0-9]+$ . Should this be changed? It may be a change in how REGEX is handled in newer versions of Cmake.

Thanks!

@mhoemmen

@mhoemmen
Copy link
Contributor

mhoemmen commented Jun 6, 2018

FYI it looks like Kokkos requires CMake 3.3 when not building with Trilinos -- does Trilinos test at all with earlier CMake versions?

@crtrott
Copy link
Member

crtrott commented Jun 7, 2018

Just go ahead issue a pull request to fix that character. Regarding CMake: looks like Trilinos wants to upgrade that soon. But yeah right now it is technically supposed to work with that older version: though we probably don't have any test whats so ever doing that.

MalachiTimothyPhillips pushed a commit to MalachiTimothyPhillips/kokkos that referenced this issue Jun 7, 2018
Invalid escape sequence \. in kokkos_functions.cmake for old cmake, so added another backslash. See: kokkos#1661 (comment)
@ibaned ibaned self-assigned this Jun 13, 2018
@ibaned ibaned added this to the 2018 July milestone Jun 13, 2018
ibaned added a commit that referenced this issue Jun 13, 2018
@ibaned ibaned added Enhancement Improve existing capability; will potentially require voting InDevelop labels Jun 13, 2018
@crtrott crtrott closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

5 participants