Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokkos CMake error (fixed in kokkos:develop) #3118

Closed
mhoemmen opened this issue Jul 15, 2018 · 6 comments
Closed

Kokkos CMake error (fixed in kokkos:develop) #3118

mhoemmen opened this issue Jul 15, 2018 · 6 comments
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. Framework tasks Framework tasks (used internally by Framework team) impacting: configure or build The issue is primarily related to configuring or building MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Kokkos

Comments

@mhoemmen
Copy link
Contributor

@trilinos/kokkos @trilinos/framework

Current Behavior

At least one Trilinos build on the Dashboard shows the following CMake error:

CMake Error at packages/kokkos/cmake/kokkos_functions.cmake:50 (string):
  Syntax error in cmake code at

    /home/jenkins/slave/workspace/Trilinos_apollo_gcc_4.9.3_cuda_8.0.44/MPI_RELEASE_DEV_DownStream_ETI_SERIAL-ON_OPENMP-OFF_PTHREAD-OFF_CUDA-ON_COMPLEX-OFF/Trilinos/packages/kokkos/cmake/kokkos_functions.cmake:50

  when parsing string

    [0-9]+\.[0-9]+\.[0-9]+$

  Invalid escape sequence \.
Call Stack (most recent call first):
  cmake/ProjectCompilerPostConfig.cmake:34 (set_kokkos_cxx_compiler)
  /home/jenkins/slave/workspace/Trilinos_apollo_gcc_4.9.3_cuda_8.0.44/Trilinos/cmake/tribits/core/package_arch/TribitsGlobalMacros.cmake:1847 (INCLUDE)
  /home/jenkins/slave/workspace/Trilinos_apollo_gcc_4.9.3_cuda_8.0.44/Trilinos/cmake/tribits/core/package_arch/TribitsProjectImpl.cmake:188 (TRIBITS_SETUP_ENV)
  /home/jenkins/slave/workspace/Trilinos_apollo_gcc_4.9.3_cuda_8.0.44/Trilinos/cmake/tribits/core/package_arch/TribitsProject.cmake:93 (TRIBITS_PROJECT_IMPL)
  CMakeLists.txt:90 (TRIBITS_PROJECT)

This is kokkos/kokkos#1661 , which has been fixed in kokkos:develop by Kokkos PR kokkos/kokkos#1662 .

Possible Solution

Wait until the next Kokkos promotion into Trilinos.

Related Issues

@mhoemmen mhoemmen added pkg: Kokkos Framework tasks Framework tasks (used internally by Framework team) impacting: configure or build The issue is primarily related to configuring or building labels Jul 15, 2018
@ibaned
Copy link
Contributor

ibaned commented Jul 16, 2018

@mhoemmen I believe this only happens for old CMake versions (< 3.0 ?) and I think @bartlettroscoe and I would rather increase our minimum required CMake version.

@mhoemmen
Copy link
Contributor Author

@ibaned I think it's less than 3.3, but yes, it's definitely an issue only for old CMake versions. I just wanted to note the current state in case people complain about the one configure failure on Trilinos' Dashboard ;-) .

@ibaned
Copy link
Contributor

ibaned commented Jul 16, 2018

Yep, makes sense. I think if its a Trilinos dashboard build then its CMake should definitely be upgraded.

@bartlettroscoe
Copy link
Member

@ibaned said:

I think if its a Trilinos dashboard build then its CMake should definitely be upgraded.

I am all for that (see #1761) . My vote would be to upgrade the minimum version of CMake today to 3.11.1 but that would break a bunch of the Trilinos builds. I think only the @trilinos/framework can fix those builds older versions of CMake.

@github-actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Jul 10, 2021
@github-actions
Copy link

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. Framework tasks Framework tasks (used internally by Framework team) impacting: configure or build The issue is primarily related to configuring or building MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Kokkos
Projects
None yet
Development

No branches or pull requests

3 participants