Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spa): add deployments #967

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Conversation

timonmasberg
Copy link
Member

@timonmasberg timonmasberg commented Jul 12, 2024

Description

This introduces the deployments' frontend with the dashboard view and a modal to sign in, update and sign off rescue stations. Each component has a test which sometimes rudimentary tests some features, but mainly is just a bootstrap with the necessary.

Also there is a change to the api, where the update mutation of a rescue station allows for optional protocol data (same flow as we currently have in the legacy application)

Checklist:

  • The title of this PR and the commit history is conform with
    the Conventional Commits specification.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings, SonarCloud reports no Vulnerabilities, Bugs or Code Smells.
  • I have added tests (unit and E2E if user-facing) that prove my fix is effective or that my feature works,
    Coverage > 80% and not less than the current coverage of the main branch.
  • The PR branch is up-to-date with the base branch. In case you merged main into your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).
  • I have included the reset.d.ts in the tsconfig.lib.json
  • I have extended the .eslintrc.json with .eslintrc.angular.json

@timonmasberg timonmasberg self-assigned this Jul 12, 2024
# Conflicts:
#	libs/spa/view/dashboard/src/lib/dashboard.component.ts
#	package-lock.json
#	package.json
It is not possible to override standalone components. Thus, leaving us with the only possibility of mocking everything the dashboard component provides (which is quite a lot)
…loyment-frontend

# Conflicts:
#	libs/shared/model/src/lib/gql.model.ts
@timonmasberg timonmasberg marked this pull request as ready for review July 12, 2024 21:07
@timonmasberg timonmasberg requested a review from JSPRH July 12, 2024 21:07
…loyment-frontend

# Conflicts:
#	package-lock.json
…loyment-frontend

# Conflicts:
#	package-lock.json
Copy link

sonarcloud bot commented Jul 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
73.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@timonmasberg timonmasberg force-pushed the feat/deployment-frontend branch 5 times, most recently from d8e110c to 86b1c88 Compare September 20, 2024 07:59
Signed-off-by: Timon Masberg <[email protected]>

# Conflicts:
#	package-lock.json
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
77.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant