-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch/v1: add suspend field to Jobs API #2232
Comments
hi @adtac I am one of the enhancement shadows for 1.21 and am reviewing this feature. I did not find graduation criteria for alpha phase in the kep. Could you please let me know if there are any? |
We don't have any criteria for alpha -- the feature will be turned off by default and we expect users to test it for the first time in alpha. Feedback from users will be a part of beta graduation, but the criteria for alpha is pretty much just the existence of the KEP. |
Hi @adtac This KEP looks good and I don't see any thing missing. However I am adding this message for the sake of completeness. Enhancements Freeze is 2 days away, Feb 9th EOD PST. Any enhancements that do not complete the following requirements by the freeze will require an exception. [DONE] |
Hi @adtac, Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them. Thanks! |
Hi @adtac , Enhancements team is currently tracking the following PR I went through the review comments and there are a few comments requiring some amount of work. However since this is the only PR in this KEP, I am leaning towards keeping the status as Thanks |
Hi @adtac, A friendly reminder that Code freeze is 4 days away, March 9th EOD PST Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back. Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST Thanks! |
Hi @adtac, since the only PR mentioned earlier has been merged, can this KEP be marked as done? |
@arunmk yes, the implementation is complete. Note that the docs PR is still open and under review. |
/assign @adtac |
/milestone v1.22 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale We can probably graduate to GA in 1.24 |
/milestone v1.24 |
Hello @adtac 👋, 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. For note, This enhancement is targeting for stage Here’s where this enhancement currently stands:
With all the boxes checked, this enhancement is ready for the upcoming 1.24 enhancements freeze. 🚀 For note, at the moment, the status of this enhancement is marked as |
Hi, KEP for stable graduation is already merged: #3115 |
Hi @adtac 👋🏻 1.24 Docs shadow here. This enhancement is marked as 'Needs Docs' for the 1.24 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT. Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thanks! |
Hello @ahg-g 👋 I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022 Please ensure the following items are completed:
For note, the status of this enhancement is currently marked as Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much! |
Docs PR: kubernetes/website#32350 |
@ahg-g, thank you so much. With the Docs PR open now, all requirements for Code Freeze are finished. The status is now |
Hello @ahg-g 👋, 1.25 Enhancements team here. Since this feature has been fully implemented and is now GA in K8s version v1.24 🎉 (which is also properly updated as I'm closing this issue for the purpose of accurate tracking for v1.25. Thank you so much for your valuable contributions. 🙏 🙂 /close |
@Priyankasaggu11929: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Enhancement Description
One-line enhancement description (can be used as a release note): Add a
suspend
field to the Jobs API to allow orchestrators to create jobs with more control over when pods are created.Kubernetes Enhancement Proposal: KEP 2232: add Suspend Job in implementable status #2234
Discussion Link:
Primary contact (assignee): @adtac
Responsible SIGs: sig-apps
Enhancement target (which target equals to which milestone):
Alpha
k/enhancements
) update PR(s): KEP 2232: add Suspend Job in implementable status #2234 (merged)k/k
) update PR(s): batch API: add suspended job kubernetes#98727 (merged)k/website
) update PR(s): job.md: add section on suspended jobs website#26466 (merged)Beta
k/enhancements
) update PR(s): suspended jobs: graduate to beta #2646 (merged)k/k
) update PR(s): graduate SuspendJob to beta kubernetes#102022 (merged)k/website
) update(s): SuspendJob: graduate to beta website#28881 (merged)GA
k/enhancements
) update PR(s): KEP-2232: Graduate suspend job to stable #3115 (merged)k/k
) update PR(s): Graduate SuspendJob to GA kubernetes#108129 (merged)k/website
) update(s): Promote SuspendJob to GA website#32333 (merged)/sig apps
The text was updated successfully, but these errors were encountered: