Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suspended jobs: graduate to beta #2646

Merged
merged 1 commit into from
Apr 30, 2021
Merged

suspended jobs: graduate to beta #2646

merged 1 commit into from
Apr 30, 2021

Conversation

adtac
Copy link
Member

@adtac adtac commented Apr 22, 2021

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2021
@adtac adtac mentioned this pull request Apr 22, 2021
Closed
12 tasks
ahg-g
ahg-g reviewed Apr 22, 2021
View reviewed changes
keps/sig-apps/2232-suspend-jobs/README.md Outdated Show resolved Hide resolved
keps/sig-apps/2232-suspend-jobs/README.md
- Metric name: `job_sync_duration_seconds` gets a new label named `action`
to allow operators to filter Job sync latency by the action performed.
The possible values for this label are:
- `reconciling` when the Job's pod creation/deletion expectations are
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this mutually exclusive with pods_created and pods_deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes:

Each sample of this metric will have exactly one of the above values for the action label.

keps/sig-apps/2232-suspend-jobs/README.md Show resolved Hide resolved
keps/sig-apps/2232-suspend-jobs/README.md Outdated Show resolved Hide resolved
soltysh
soltysh reviewed Apr 26, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRR is missing here

@alculquicondor
Copy link
Member

@adtac you have to update the existing file in https:/kubernetes/enhancements/tree/master/keps/prod-readiness/sig-apps

@adtac adtac force-pushed the suspend-beta branch 5 times, most recently from 4db92e0 to 28604b9 Compare April 26, 2021 19:50
@ahg-g
Copy link
Member

ahg-g commented Apr 26, 2021

latest commit looks good to me

soltysh
soltysh approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2021
wojtek-t
wojtek-t reviewed Apr 27, 2021
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor comments - and please rebase

keps/sig-apps/2232-suspend-jobs/README.md Outdated
@@ -385,78 +390,86 @@ field.

* **Are there any tests for feature enablement/disablement?** No.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit tests for it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, we do have integration tests that test feature enablement exhaustively. updated the KEP.

keps/sig-apps/2232-suspend-jobs/README.md
While the above list isn't exhaustive, they're signals in favour of rollbacks.

* **Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path
tested?** <!-- I'll answer this after implementation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do the same thing I did here:
https:/kubernetes/enhancements/pull/2538/files

suspended jobs: graduate to beta
6aae0b5 
Signed-off-by: Adhityaa Chandrasekar <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2021
adtac
adtac commented Apr 27, 2021
View reviewed changes
Copy link
Member Author

@adtac adtac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squashed & rebased

keps/sig-apps/2232-suspend-jobs/README.md Outdated
@@ -385,78 +390,86 @@ field.

* **Are there any tests for feature enablement/disablement?** No.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, we do have integration tests that test feature enablement exhaustively. updated the KEP.

@wojtek-t wojtek-t self-assigned this Apr 28, 2021
@wojtek-t
Copy link
Member

/lgtm
/approve [PRR]

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adtac, soltysh, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6ae9f53 into kubernetes:master Apr 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 30, 2021
@adtac adtac mentioned this pull request May 14, 2021
Merged
@carlisia
Copy link

Hello @adtac 👋, 1.22 Docs Shadow here.
This enhancement is marked as ‘Needs Docs’ for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@ahg-g ahg-g ahg-g left review comments

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
7 participants
@adtac @alculquicondor @ahg-g @wojtek-t @k8s-ci-robot @carlisia @soltysh