Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UpgradeConfiguration/ResetConfiguration API types #2489

Closed
neolit123 opened this issue May 25, 2021 · 10 comments
Closed

add UpgradeConfiguration/ResetConfiguration API types #2489

neolit123 opened this issue May 25, 2021 · 10 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@neolit123
Copy link
Member

neolit123 commented May 25, 2021

kubeadm currently has some matching configuration formats for its main commands.

join - JoinConfiguration
init - InitConfiguration
upgrade - none
reset - none

we should eventually provide API types for all main commands to avoid flags.
note this was not discussed as part of v1beta3, so it can happen in a future API version.


these are added in v1beta4

upgrade

upgrade does not have a config, forcing users to rely on flags only and forcing us as maintainers to have some flags unique to "upgrade" only.

we should add a scoped UpgradeConfiguration structure that can hold a number of relevant options to upgrade.
--config for upgrade should accept this configuration and not ClusterConfiguration | InitConfiguration...

maybe CC too:
#1681


reset

this makes sense for consistency with respect to skipPhases. one other option is --force.
overall the structure for reset would be very minimal since it does not have a lot of options.

@neolit123 neolit123 added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 25, 2021
@neolit123 neolit123 added this to the Next milestone May 25, 2021
@neolit123
Copy link
Member Author

we discussed with @fabriziopandini during the kubeadm office hours today that we should delay the addition of these new structures until we have a better understanding of nodespecific configuration and the kubeadm roadmap as a whole.
#2367

@wangyysde
Copy link
Member

/cc @wangyysde

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2021
@neolit123 neolit123 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 8, 2021
@chendave
Copy link
Member

/remove-lifecycle stale

@neolit123 is the time to pick this up? I saw the KEP is closed with no progress yet.

@neolit123
Copy link
Member Author

we should likely book another kubeadm office hours to discuss this. but if you'd like you can also draft a google doc proposal about it following the kep template on which we can comment.

@chendave
Copy link
Member

sure, I am going to do more investigation on this and make sure I understand the whole pic before sending the google doc.

/assgin

@chendave
Copy link
Member

/assign

@chendave
Copy link
Member

sent the doc to the mailing list, paste the link here as well: https://docs.google.com/document/d/1R4zLtgDadNM8_N2VzS0DI2mADcYmkyJ3L7lJVpbyZsA

@chendave
Copy link
Member

@neolit123 pls help to review at your convenience, thanks! :)

@neolit123
Copy link
Member Author

thanks @chendave . i did an initial pass on the doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

6 participants