kubeadm: implementation of `UpgradeConfiguration` API types #114062

chendave · 2022-11-22T08:23:40Z

Signed-off-by: Dave Chen [email protected]

/kind feature

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #kubernetes/kubeadm#2489
Part of #kubernetes/kubeadm#2890

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://docs.google.com/document/d/1R4zLtgDadNM8_N2VzS0DI2mADcYmkyJ3L7lJVpbyZsA

TODO:

migrated to v1beta4 when the API version is ready
split the cleanup out from this PR or in separate commits
fetch configmaps from cluster always: component config is overwritten after upgrading by kubeadm kubeadm#2785

k8s-ci-robot · 2022-11-22T08:23:43Z

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Nov 22 03:29:08 UTC 2022.

k8s-ci-robot · 2022-11-22T08:23:48Z

@chendave: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chendave · 2022-11-22T08:25:06Z

/hold

going to be migrated to v1beta4 when the API version is ready.
will split into couple of commits as this pr contains several cleanup as well.

chendave · 2023-02-10T06:17:21Z

Just took some time to rebase, and also cc to all active contributor to level up the visibility. @pacoxu @SataQiu @neolit123

Basically, the change to support resetCfg (#113583) and the upgradeCfg (#114062) is ready.

I understood we still need to wait for new API ready or well prepared in the advance, I would appreciated for any early review / comments for those two change.

pacoxu · 2023-02-13T05:23:49Z

If I understand correctly, the comments in https://docs.google.com/document/d/1R4zLtgDadNM8_N2VzS0DI2mADcYmkyJ3L7lJVpbyZsA/edit# shows that we should add new API in new API version v1beta4.

chendave · 2023-02-14T01:50:36Z

If I understand correctly, the comments in https://docs.google.com/document/d/1R4zLtgDadNM8_N2VzS0DI2mADcYmkyJ3L7lJVpbyZsA/edit# shows that we should add new API in new API version v1beta4.

yes, migrate to the new API should be easy.

pacoxu · 2023-02-14T01:58:06Z

yes, migrate to the new API should be easy.

Do you mean that we can start reviewing this PR now or we should wait until this is migrated to the new API?
Is this targeted for v1.27 or the next release cycle(maybe v1.28)?

chendave · 2023-02-14T02:16:28Z

@pacoxu pls help to review if you have some bandwidth or else it is fine to defer this to a future release cycle. AFAIK, this is not targeted for any version yet.

SataQiu · 2023-02-16T10:03:55Z

If I understand correctly, the comments in https://docs.google.com/document/d/1R4zLtgDadNM8_N2VzS0DI2mADcYmkyJ3L7lJVpbyZsA/edit# shows that we should add new API in new API version v1beta4.

Yes, v1beta3 is locked and new features cannot be added. Maybe we should first update KEP: https:/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/970-kubeadm-config

chendave · 2023-10-20T10:47:08Z

update 10/20/23

address @neolit123 's comments
added two separate commits for refactor 8777059 and 65f5152
re-org each commits and cleanup all unnecessary changes.

Overall, the big change for this update is refactoring, I did my best to make those changes easier to review.

@neolit123 @pacoxu @SataQiu PTAL when you got a chance, thanks!

chendave · 2023-10-20T11:06:53Z

/retest-required

chendave · 2023-10-20T11:44:25Z

cmd/kubeadm/app/cmd/upgrade/common.go

- klog.V(1).Info("running preflight checks")
- if err := runPreflightChecks(client, ignorePreflightErrorsSet, printer); err != nil {
- return nil, nil, nil, err
- }


this diff is necessary, I must move this code block up before the call to FetchInitConfigurationFromCluster, so that the interaction with cluster will not happen, this is because some testcases want to check the logic around this runPreflightChecks.

see this testcase:
cmd/kubeadm/app/cmd/upgrade TestEnforceRequirements/Fail_pre-flight_check

and the log from here: https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/114062/pull-kubernetes-unit/1715315999886020608/build-log.txt

Signed-off-by: Dave Chen <[email protected]>

…ration` Instead of load from config file to populate `InitConfiguration`, the config file is expected to hold the config for upgrade only. The old logic is that if the config file has "initConfiguration/ ClusterConfiguration" defined, then it assumes that user wants to reconfigure the cluster based on the new configuration. upgrade itself should be non-mutable, so the logic to `reconfigure` will not be supported, and the init config should be fetched from cluster instead. Signed-off-by: Dave Chen <[email protected]>

The function use to load "InitConfiguration/ClusterConfiguration/ componentConfig" from a config file, now that we have a `upgradeConfiguration` API, the function `loadConfig` can be removed now. Signed-off-by: Dave Chen <[email protected]>

Those constants will be used for `kubeadm upgrade plan` or `kubeadm upgrade apply` Signed-off-by: Dave Chen <[email protected]>

Signed-off-by: Dave Chen <[email protected]>

…f/node` Signed-off-by: Dave Chen <[email protected]>

k8s-ci-robot · 2023-12-16T17:40:20Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chendave · 2024-01-28T05:34:25Z

Just note I don't have time on this at the moment, someone else can help to continue the efforts as it's pretty close I believe, or else I can come back to this when some mess from me are all settled.

calvin0327 · 2024-01-29T01:42:57Z

@chendave I'm interested in this, can I work on this?

neolit123 · 2024-02-01T12:38:52Z

closing in favor of #123068
thanks for the work on this!

neolit123 · 2024-02-01T12:38:55Z

/close

k8s-ci-robot · 2024-02-01T12:39:02Z

@neolit123: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 22, 2022

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2022

k8s-ci-robot requested review from pacoxu and RA489 November 22, 2022 08:23

k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 22, 2022

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2022

chendave mentioned this pull request Nov 28, 2022

component config is overwritten after upgrading by kubeadm kubernetes/kubeadm#2785

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2022

chendave force-pushed the POC_upgradeCfg branch 2 times, most recently from a0b4567 to d230a11 Compare February 10, 2023 06:13

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2023

chendave force-pushed the POC_upgradeCfg branch from d230a11 to 28b2123 Compare February 10, 2023 07:00

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2023

chendave force-pushed the POC_upgradeCfg branch from 28b2123 to 91789da Compare March 6, 2023 03:42

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 20, 2023

chendave force-pushed the POC_upgradeCfg branch from a908660 to 50703c8 Compare October 20, 2023 11:40

chendave commented Oct 20, 2023

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2023

chendave added 2 commits November 1, 2023 13:30

kubeadm: Add UpgradeConfiguration for v1beta4

1f93a97

Signed-off-by: Dave Chen <[email protected]>

kubeadm: fix fuzzing for upgradeConfiguration

7ce0207

Signed-off-by: Dave Chen <[email protected]>

chendave force-pushed the POC_upgradeCfg branch from 50703c8 to 6720bd4 Compare November 1, 2023 06:00

chendave added 4 commits November 1, 2023 17:14

kubeadm: define more constant for kubeadm upgrade

b059e17

Those constants will be used for `kubeadm upgrade plan` or `kubeadm upgrade apply` Signed-off-by: Dave Chen <[email protected]>

kubeadm: Adapt the apply and plan for UpgradeConfiguration

aca60e6

Signed-off-by: Dave Chen <[email protected]>

chendave force-pushed the POC_upgradeCfg branch from 6720bd4 to f6a4f50 Compare November 1, 2023 09:15

chendave added 3 commits November 2, 2023 16:29

kubeadm: Adapt the upgrade diff for UpgradeConfiguration

f20db38

Signed-off-by: Dave Chen <[email protected]>

kubeadm: Adapt the upgrade node for UpgradeConfiguration

284667a

Signed-off-by: Dave Chen <[email protected]>

kubeadm: Validate mixed arguments for `kubeadm upgrade plan/apply/dif…

bca3e14

…f/node` Signed-off-by: Dave Chen <[email protected]>

chendave force-pushed the POC_upgradeCfg branch from f6a4f50 to bca3e14 Compare November 2, 2023 08:30

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2023

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2023

neolit123 mentioned this pull request Jan 2, 2024

add UpgradeConfiguration/ResetConfiguration API types kubernetes/kubeadm#2489

Closed

dims added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 4, 2024

calvin0327 mentioned this pull request Feb 1, 2024

kubeadm: implementation of UpgradeConfiguration API types #123068

Merged

k8s-ci-robot closed this Feb 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubeadm: implementation of `UpgradeConfiguration` API types #114062

kubeadm: implementation of `UpgradeConfiguration` API types #114062

chendave commented Nov 22, 2022 •

edited

Loading

k8s-ci-robot commented Nov 22, 2022

k8s-ci-robot commented Nov 22, 2022

chendave commented Nov 22, 2022 •

edited

Loading

chendave commented Feb 10, 2023

pacoxu commented Feb 13, 2023

chendave commented Feb 14, 2023

pacoxu commented Feb 14, 2023

chendave commented Feb 14, 2023

SataQiu commented Feb 16, 2023

chendave commented Oct 20, 2023

chendave commented Oct 20, 2023

chendave Oct 20, 2023

k8s-ci-robot commented Dec 16, 2023

chendave commented Jan 28, 2024

calvin0327 commented Jan 29, 2024

neolit123 commented Feb 1, 2024

neolit123 commented Feb 1, 2024

k8s-ci-robot commented Feb 1, 2024

kubeadm: implementation of UpgradeConfiguration API types #114062

kubeadm: implementation of UpgradeConfiguration API types #114062

Conversation

chendave commented Nov 22, 2022 • edited Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Nov 22, 2022

k8s-ci-robot commented Nov 22, 2022

chendave commented Nov 22, 2022 • edited Loading

chendave commented Feb 10, 2023

pacoxu commented Feb 13, 2023

chendave commented Feb 14, 2023

pacoxu commented Feb 14, 2023

chendave commented Feb 14, 2023

SataQiu commented Feb 16, 2023

chendave commented Oct 20, 2023

update 10/20/23

chendave commented Oct 20, 2023

chendave Oct 20, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 16, 2023

chendave commented Jan 28, 2024

calvin0327 commented Jan 29, 2024

neolit123 commented Feb 1, 2024

neolit123 commented Feb 1, 2024

k8s-ci-robot commented Feb 1, 2024

kubeadm: implementation of `UpgradeConfiguration` API types #114062

kubeadm: implementation of `UpgradeConfiguration` API types #114062

chendave commented Nov 22, 2022 •

edited

Loading

chendave commented Nov 22, 2022 •

edited

Loading