-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flags introduced by dependencies? #14320
Comments
@cjwagner @fejta @Katharine @clarketm This is another reason we should reconsider the |
boo! |
Yeah that's definitely not great. Tekton is at least one thing that prevents us from doing minor module upgrades (since it transitively depends on k8s.io/kubernetes) Filed an issue about this over in the pipeline repo. /cc @cjwagner @bobcatfish @wbrefvem Thoughts? |
This isn't something we can fix on our end short of removing the Prow + Pipelines integration right? If thats the case it would be great to see this fixed by the Pipelines project, especially since we're probably not the only ones with these problems. |
We can (and IMO should) just copy-paste the types we need from |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What should be cleaned up or changed:
flags are introduced by dependencies.
Ideally, we may want to do some refactoring in the dependency's repo.
Provide any links for context:
Those flags are added via
var
section, such as git-image. Anycmd
depending on it will have to do workaround likeflag.NewFlagSet
to exlude them.The text was updated successfully, but these errors were encountered: