Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing the pipeline api pollutes flags #1309

Closed
fejta opened this issue Sep 13, 2019 · 1 comment · Fixed by #1378
Closed

importing the pipeline api pollutes flags #1309

fejta opened this issue Sep 13, 2019 · 1 comment · Fixed by #1378
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@fejta
Copy link

fejta commented Sep 13, 2019

Importing the pipeline api causes a bunch of global flags to get introduced, for example:

gitImage = flag.String("git-image", "override-with-git:latest",
"The container image containing our Git binary.")
)

Ideally people should be able to consume this api definition without polluting their flag namespace.
Can we move these flags into the pipeline controller and/or move them inside an optionally called function rather than global vars / init statements which everyone has to run?

ref kubernetes/test-infra#14320

@bobcatfish bobcatfish added this to the Pipelines 0.8 🐱 milestone Sep 13, 2019
@vdemeester
Copy link
Member

/assign
/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 16, 2019
@bobcatfish bobcatfish added the kind/bug Categorizes issue or PR as related to a bug. label Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
4 participants