lib/hsh.c: rename hsh local variable #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hsh local variable name conflicts with the function prototype of hsh() in hsh.h, causing the following build issues with old compilers (gcc 4.7): hsh.c: In function 'hsh': hsh.c:28:21: error: declaration of 'hsh' shadows a global declaration [-Werror=shadow] hsh.c:26:1: error: shadowed declaration is here [-Werror=shadow] hsh.c: In function 'hsh_buf': hsh.c:60:21: error: declaration of 'hsh' shadows a global declaration [-Werror=shadow] hsh.c:26:1: error: shadowed declaration is here [-Werror=shadow] Therefore, we rename this local variable to _hsh. Signed-off-by: Thomas Petazzoni <[email protected]> [Fabrice: Resent PR as #51 was closed but meson doesn't fix this issue)] Signed-off-by: Fabrice Fontaine <[email protected]>
sarroutbi
approved these changes
Jan 10, 2022
|
Do you plan on merging this PR? |
grooverdan
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hshlocal variable name conflicts with the function prototype ofhsh()inhsh.h, causing the following build issues with old compilers (gcc 4.7):Therefore, we rename this local variable to
_hsh.Signed-off-by: Thomas Petazzoni [email protected]
[Fabrice: Resent PR as #51 was closed but meson doesn't fix this issue)]
Signed-off-by: Fabrice Fontaine [email protected]