Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/hsh.c: rename hsh local variable #111

Merged
merged 1 commit into from
Jan 12, 2023
Merged

lib/hsh.c: rename hsh local variable #111

merged 1 commit into from
Jan 12, 2023

Commits on Jan 1, 2022

  1. lib/hsh.c: rename hsh local variable 

    The hsh local variable name conflicts with the function prototype of
hsh() in hsh.h, causing the following build issues with old compilers
(gcc 4.7):

hsh.c: In function 'hsh':
hsh.c:28:21: error: declaration of 'hsh' shadows a global declaration [-Werror=shadow]
hsh.c:26:1: error: shadowed declaration is here [-Werror=shadow]
hsh.c: In function 'hsh_buf':
hsh.c:60:21: error: declaration of 'hsh' shadows a global declaration [-Werror=shadow]
hsh.c:26:1: error: shadowed declaration is here [-Werror=shadow]

Therefore, we rename this local variable to _hsh.

Signed-off-by: Thomas Petazzoni <[email protected]>
[Fabrice: Resent PR as #51 was closed but meson doesn't fix this issue)]
Signed-off-by: Fabrice Fontaine <[email protected]>
    @tpetazzoni @ffontaine
    tpetazzoni authored and ffontaine committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    f4c1463 View commit details
    Browse the repository at this point in the history