Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of IssueService::getComments method #305

Closed
wants to merge 5 commits into from

Conversation

rmuradyan
Copy link

Fixed error in IssueService::getComments method.

@rmuradyan
Copy link
Author

Big thank you for your library!

@lesstif
Copy link
Owner

lesstif commented Mar 28, 2020

@rmuradyan thanks for your contribution.

before merge to your changes, i was run get comments feature on my JIRA Instance(standalone 8.2.3), but working correctly.

could you to explain why this PR is hotfix?

Only last file was represented in upload results.
@rmuradyan
Copy link
Author

Hi! Changed the title.
Should I target this PR to develop branch?

@rmuradyan rmuradyan changed the title Hotfix Fixed error in IssueService::getComments method. Mar 29, 2020
@lesstif
Copy link
Owner

lesstif commented Mar 30, 2020

hi @rmuradyan

i could't get the any exception with getComments() method.

could you explain to me that your environment and more information(error message, stack trace, etc...) for fixing problem please?

@lesstif lesstif mentioned this pull request Mar 30, 2020
@rmuradyan
Copy link
Author

rmuradyan commented Mar 31, 2020

Good day! Yes. Exception is not got. But target structure is not right. We create a Comment object when expected to get Comments object, that was designed for it.

@rmuradyan rmuradyan closed this Mar 31, 2020
@rmuradyan rmuradyan reopened this Apr 2, 2020
@rmuradyan
Copy link
Author

rmuradyan commented Apr 2, 2020

The point is that target structure of getComments method supposed to be Comments object, but Comment object is given. We should pass a "Comments" object to the mapper to map fields correctly. So that json fields were mapped to the object of Comments class that has all the necessary fields, such as "total", "comments", "startAt" and "maxResults" and is intended for this. Now all the fields are filling into a Comment object, that is semantically right.

@rmuradyan rmuradyan changed the title Fixed error in IssueService::getComments method. Improvement of IssueService::getComments method Apr 2, 2020
rmuradyan and others added 2 commits April 3, 2020 01:28
Only last file was represented in upload results.
@lesstif
Copy link
Owner

lesstif commented Apr 3, 2020

hi @rmuradyan

your PR does't based on the latest sources.

could you pull latest and resend PR please.? (see #306 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants