Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed IssueService::getComments() method not mapping to the correct object (Comments) #432

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Fixed IssueService::getComments() method not mapping to the correct object (Comments) #432

merged 1 commit into from
Jun 16, 2022

Conversation

MelvinSnijders
Copy link
Contributor

This PR fixes #305, just updated it with the latest version.

@lesstif
Copy link
Owner

lesstif commented Jun 16, 2022

Hi @MelvinSnijders .

I'm so sorry for the late reply.
I changed a lot of code, so your PR is broken.
Could you pull the recent commit and resend PR, please?

@MelvinSnijders
Copy link
Contributor Author

Hey! This PR still works with the latest version!

@lesstif lesstif merged commit fce4fdd into lesstif:main Jun 16, 2022
lesstif added a commit that referenced this pull request Jun 16, 2022
@lesstif
Merge branch 'main' of github.com:lesstif/php-jira-rest-client
8f9bbec 
* 'main' of github.com:lesstif/php-jira-rest-client:
  Fix comment method not returning multiple comments (#432)
  Apply fixes from StyleCI (#443)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MelvinSnijders @lesstif