Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL decode updated translation messages #288

Merged
merged 1 commit into from
Oct 5, 2017
Merged

URL decode updated translation messages #288

merged 1 commit into from
Oct 5, 2017

Conversation

jorissteyn
Copy link
Contributor

Since PR #72, all translation updates are sent URL-encoded to the
backend. To allow spaces and markup in translated messages the
datagrid handler must decode the messages before saving them.

Fixes issue #286

URL decode updated translation messages
575219a 
Since PR lexik#72, all translation updates are sent URL-encoded to the
backend. To allow spaces and markup in translated messages the
datagrid handler must decode the messages before saving them.

Fixes issue lexik#286
jorissteyn pushed a commit to SURFnet/sp-dashboard that referenced this pull request Oct 5, 2017
Allow markup in translated messages
49e4f34 
Temporarily using a fork of the translation bundle until the PR is
merged:

    lexik/LexikTranslationBundle#288
@sdieunidou sdieunidou merged commit 93410b1 into lexik:master Oct 5, 2017
jorissteyn pushed a commit to SURFnet/sp-dashboard that referenced this pull request Oct 5, 2017
Allow markup in translated messages
ff0af3e 
Temporarily using a fork of the translation bundle until the PR is
merged:

    lexik/LexikTranslationBundle#288
@igops
Copy link

igops commented Oct 5, 2017 •
edited
Loading

It is more than 3 years since #72. What's the actual reason of the issue?

@jorissteyn
Copy link
Contributor Author

Good point, looking at it again, I think I can explain the cause.

Commit d95a301 in PR #278 replaced started using angulars httpParamSerializer component. The serializer does the encoding required so there's no need for encodeURIComponent.

@jorissteyn jorissteyn mentioned this pull request Oct 6, 2017
Merged
jorissteyn pushed a commit to SURFnet/sp-dashboard that referenced this pull request Oct 6, 2017
Update lexik translation bundle to latest encoding fix branch
5a0dd2d 
See: lexik/LexikTranslationBundle#288
@igops
Copy link

igops commented Oct 6, 2017

@jorissteyn thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorissteyn @igops @sdieunidou