Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double-encoding of translations in the web UI #289

Merged
merged 2 commits into from
Nov 29, 2017

Conversation

jorissteyn
Copy link
Contributor

@jorissteyn jorissteyn commented Oct 6, 2017

Commit d95a301 in PR #278 started using angulars
httpParamSerializer component. The serializer does the encoding
required so there's no need for encodeURIComponent.

See #288, #72

Joris Steyn added 2 commits October 6, 2017 08:48
Commit d95a301 in PR lexik#278 replaced started using angulars
httpParamSerializer component. The serializer does the encoding
required so there's no need for encodeURIComponent.
@gilles-g
Copy link
Member

👍

@gilles-g gilles-g merged commit 5baee77 into lexik:master Nov 29, 2017
ubiedigital pushed a commit to ubiedigital/LexikTranslationBundle that referenced this pull request Mar 12, 2018
ubiedigital pushed a commit to ubiedigital/LexikTranslationBundle that referenced this pull request Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants