Add Symfony 4.3 kernel.locale_aware tag #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony 4.3 does not use the TranslatorListener anymore to set the locale. Instead, the LocaleAwareListener is used to collect locale aware services and set the locale on them. This tag makes sure the Lexik translator is marked as a locale aware service so the locale is set correctly in Symfony >= 4.3 without breaking compatibility with earlier versions.
|
Maybe you should put a check around your new line that the KernelId is bigger than 40301 (or even 40300) because this is something new |
|
Not necessary. The tag is ignored in earlier versions. |
|
Could you please have a look at this PR and merge it? Thx! |
|
Last commit 8 months ago, simple PR takes more than 2 months to merge, is this package still maintained? Otherwise it is better to resort to alternatives. |
|
@endroid Hi, Sorry for waiting, I take care of it. |
WL-arek
pushed a commit
to wlogic/LexikTranslationBundle
that referenced
this pull request
Mar 29, 2021
* lexik/3.4: Fix travis for 3.4 (lexik#376) Add Symfony 4.3 kernel.locale_aware tag (lexik#347) Sf4 fix (lexik#331) Update LexikTranslationBundle.es.yml (lexik#339) class names are declared in StudlyCaps (lexik#328) 🐛 Fix render twig in controller for overriding purpose (lexik#311) Fix BC with Symfony 2.8 LTS (lexik#322) add sf4 support (lexik#320) Added modified flag in order to fix merge algorithm (lexik#261) Remove useless check on http method (lexik#315) Corrected ExportTranslationsCommand service id. (lexik#314) Fix symfony >= 3.4 user deprecated. (lexik#310) lexik#306. set public of 'translate' alias for compatibility with other components in SF4. (lexik#309) Symfony 4 support (lexik#305) Minor typo fixes (lexik#296) Replace Propel to Propel2. (lexik#302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 4.3 does not use the TranslatorListener anymore to set the locale. Instead, the LocaleAwareListener is used to collect locale aware services and set the locale on them. This tag makes sure the Lexik translator is marked as a locale aware service so the locale is set correctly in Symfony >= 4.3 without breaking compatibility with earlier versions.