Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 4 support #305

Merged
merged 2 commits into from
Feb 19, 2018
Merged

Symfony 4 support #305

merged 2 commits into from
Feb 19, 2018

Conversation

Bukashk0zzz
Copy link
Contributor

@Bukashk0zzz Bukashk0zzz commented Feb 14, 2018 •
edited
Loading

😢

@Bukashk0zzz Bukashk0zzz force-pushed the symfony4 branch 3 times, most recently from 5b26380 to 946901b Compare February 15, 2018 07:12
@eugenekurasov
Copy link
Contributor

👍 - now need fix tests and PR done )

@Bukashk0zzz Bukashk0zzz force-pushed the symfony4 branch 9 times, most recently from 3a2b706 to 3928cac Compare February 15, 2018 11:33
@eugenekurasov
Copy link
Contributor

eugenekurasov commented Feb 15, 2018 •
edited
Loading

@Spike31 can you merge this PR?
Closes:
#294

@Bukashk0zzz
Copy link
Contributor Author

Bukashk0zzz commented Feb 15, 2018 •
edited
Loading

🥂😎

@eugenekurasov Thanks for support.

@eugenekurasov eugenekurasov mentioned this pull request Feb 15, 2018
Closed
@gilles-g gilles-g self-requested a review February 16, 2018 17:17
@gilles-g gilles-g self-assigned this Feb 16, 2018
@gilles-g gilles-g removed their request for review February 16, 2018 17:17
@gilles-g
Copy link
Member

Good job!
I will merge and create a tag next week.

@rodmarzavala
Copy link

Thanks for your time && work guys!

@gilles-g gilles-g merged commit 898b4cc into lexik:master Feb 19, 2018
@jlemale
Copy link

jlemale commented Feb 19, 2018

Nice work guys !
But I just noticed the export command is missing

@eugenekurasov
Copy link
Contributor

Hi,
@jlemale can you Create issue and put notice message?

@jlemale
Copy link

jlemale commented Feb 19, 2018

@eugenekurasov Hi, I've just created one : #306

ubiedigital pushed a commit to ubiedigital/LexikTranslationBundle that referenced this pull request Mar 12, 2018
@Bukashk0zzz
Symfony 4 support (lexik#305)
6e48cb7
ubiedigital pushed a commit to ubiedigital/LexikTranslationBundle that referenced this pull request Mar 12, 2018
@Bukashk0zzz
Symfony 4 support (lexik#305)
b1b9710
WL-arek pushed a commit to wlogic/LexikTranslationBundle that referenced this pull request Mar 29, 2021
@wiertlewski
Merge remote-tracking branch 'lexik/3.4' into feature/sp-2084
63e0815 
* lexik/3.4:
  Fix travis for 3.4 (lexik#376)
  Add Symfony 4.3 kernel.locale_aware tag (lexik#347)
  Sf4 fix (lexik#331)
  Update LexikTranslationBundle.es.yml (lexik#339)
  class names are declared in StudlyCaps (lexik#328)
  🐛 Fix render twig in controller for overriding purpose (lexik#311)
  Fix BC with Symfony 2.8 LTS (lexik#322)
  add sf4 support (lexik#320)
  Added modified flag in order to fix merge algorithm (lexik#261)
  Remove useless check on http method (lexik#315)
  Corrected ExportTranslationsCommand service id. (lexik#314)
  Fix symfony >= 3.4 user deprecated. (lexik#310)
  lexik#306. set public of 'translate' alias for compatibility with other components in SF4. (lexik#309)
  Symfony 4 support (lexik#305)
  Minor typo fixes (lexik#296)
  Replace Propel to Propel2. (lexik#302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gilles-g gilles-g

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bukashk0zzz @eugenekurasov @gilles-g @rodmarzavala @jlemale