Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

use libp2p-crypto #18

Merged
merged 6 commits into from
Dec 20, 2017
Merged

use libp2p-crypto #18

merged 6 commits into from
Dec 20, 2017

Conversation

richardschneider
Copy link
Contributor

Remove node-forge dependency, #7

@richardschneider richardschneider mentioned this pull request Dec 19, 2017
Merged
@daviddias
Copy link
Member

released libp2p-crypto ⚡️

@richardschneider
Copy link
Contributor Author

@diasdavid Thanks for libp2p-crypto release. just waiting on libp2p/js-peer-id#73, then I can remove WIP and you can review.

@richardschneider richardschneider changed the title [WIP] use libp2p-crypto use libp2p-crypto Dec 20, 2017
daviddias
daviddias approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it could use more tests though. Good 1st iteration.

@richardschneider
Copy link
Contributor Author

@diasdavid There are 37 tests and I think the code coverage is good.

Please tell me what is required for the 2nd iteration.

@richardschneider
Copy link
Contributor Author

@diasdavid Please read the entire keychain.spec not the diff.

@daviddias daviddias merged commit c1627a9 into master Dec 20, 2017
@daviddias
Copy link
Member

As said, looks good now :) Thanks for creating this ❤️

@daviddias daviddias deleted the libp2p-keys branch December 20, 2017 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardschneider @daviddias