fix: use labels to differentiate interfaces for metrics

[achingbrain]

Instead of inserting the interface address into the metric name, use the metric address as a label prefix for the value being reported.

This allows our metric names to be stable even if you don't know the ip/port combo that will be used ahead of time.

The tradeoff is the label names may change between restarts if the port number changes, but we have to apply a disambguator somewhere.

Depends on:

• fix: allow multiple consumers of metrics js-libp2p-prometheus-metrics#6

[mpetrunic]

@achingbrain Should we wait for the libp2p release with updated prometheus metrics before merging this?

[achingbrain]

No need - this module uses the new metrics interface as of v6

[mpetrunic]

No need - this module uses the new metrics interface as of v6

I get that, but will it cause perf issues before we update prometheus metrics in libp2p?

[achingbrain]

Are you talking about using it with the current libp2p release? If so tsc should complain as [email protected] supplies @libp2p/[email protected] and this module requires @libp2p/[email protected] - it should be used with libp2p@next

[mpetrunic]

Are you talking about using it with the current libp2p release? If so tsc should complain as [email protected] supplies @libp2p/[email protected] and this module requires @libp2p/[email protected] - it should be used with libp2p@next

Ah I see!

[github-actions]

🎉 This PR is included in version 6.0.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀