Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix: use labels to differentiate interfaces for metrics #230

Merged
merged 1 commit into from
Nov 22, 2022

Commits on Nov 20, 2022

  1. fix: use labels to differentiate interfaces for metrics

    Instead of inserting the interface address into the metric name,
    use the metric address as a label prefix for the value being reported.
    
    This allows our metric names to be stable even if you don't
    know the ip/port combo that will be used ahead of time.
    
    The tradeoff is the label names may change between restarts if
    the port number changes, but we have to apply a disambguator somewhere.
    
    Depends on:
    
    - [ ] libp2p/js-libp2p-prometheus-metrics#6
    achingbrain committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    3797d77 View commit details
    Browse the repository at this point in the history