Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update delegate example to include ipfs setup instructions #371

Closed
wants to merge 2 commits into from

Conversation

jacobheun
Copy link
Contributor

This updates the delegate routing example to include instructions for setting up the go-ipfs node locally to support the needed API endpoints.

I also added an "Add Data" field to the UI and instructions to demonstrate content providing being delegable.

docs: add the ability to add content via delegate routing
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/delegated-routing/README.md Outdated Show resolved Hide resolved
examples/delegated-routing/README.md Outdated Show resolved Hide resolved
@lidel
Copy link
Member

lidel commented Jun 26, 2019

I tried to follow instructions but I am getting error 404 when calling dht/findpeer with latest go-ipfs master as noted in ipfs/js-ipfs#2155 (comment):

For the record, I was unsuccessful with Gateway.APICommands and go-ipfs v0.4.21-rc3. Seems that neither ipfs/kubo#5565 nor ipfs/kubo#5565 were merged, and undocumented APICommands setting added in ipfs/go-ipfs-config#10 is simply ignored.

2019-06-26_23-58

Any Idea what I am missing?

@jacobheun
Copy link
Contributor Author

@lidel I started with a fresh setup locally and I am hitting issues now too. Going to look more into this, I'm assuming it's a configuration issue because my ipfs version has not changed.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobheun fyi Gateway.APICommands is not wired to anything in go-ipfs (ipfs/kubo#5565 (comment)), which blocks these docs from being useful.

@alanshaw
Copy link
Member

I'm planning on giving this a wirl tomorrow - will let you know how it works out!

@olizilla
Copy link
Contributor

@alanshaw but tomorrow never came.

@alanshaw
Copy link
Member

@autonome
Copy link

I'll never forget the look in Oli's eyes when I brought up that movie in the course of regular conversation.

@lidel
Copy link
Member

lidel commented Apr 7, 2021

Yikes, we forgot about this one 🙈
I filled ipfs/kubo#8059 and added it to our maintenance backlog.
(check it out if you have strong feelings about how Gateway.APICommands should work)

@vasco-santos
Copy link
Member

@lidel this is quite outdated. We should close this as #507 (comment) is the new PR, which is also blocked

@lidel
Copy link
Member

lidel commented Apr 7, 2021

K, let's continue in #507 (comment)

@lidel lidel closed this Apr 7, 2021
@achingbrain achingbrain deleted the docs/delegate-example branch May 18, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants