Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: examples/delegated-routing #507

Closed
wants to merge 5 commits into from

Conversation

vasco-santos
Copy link
Member

This PR refactors the delegated-routing example to the refactored async js-libp2p.

@vasco-santos vasco-santos force-pushed the refactor/examples-delegated-routing branch from fd049f1 to aa9a5ba Compare December 11, 2019 10:24
"react": "^16.8.6",
"react-dom": "^16.8.6",
"react-scripts": "2.1.8"
"ipfs": "~0.40.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get libp2p to js-ipfs before getting this to work.

However, I could also not test this with #master . Do we need to run go-ipfs in the specific branch mentioned in the README?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some configuration issues that need to be resolved, see #371 (review).

In regards to requiring ipfs, we may want to revisit this example and only have libp2p in the client. The example cats a file right now, but in reality we just need to find things on the network via the delegate node.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this example, should we have a js-libp2p node running and providing a few cid that we can then find with the app example?

@vasco-santos vasco-santos force-pushed the refactor/examples-delegated-routing branch from b7c782f to 1eaf761 Compare July 7, 2020 16:57
@vasco-santos vasco-santos changed the base branch from refactor/async-await to master July 7, 2020 16:57
@@ -0,0 +1,3 @@
# required because react-scripts scans *up* the tree from this project and finds
# a conflicting version of eslint in the node_modules dir for js-ipfs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? js-ipfs doesn't have a runtime dependency on eslint? Maybe if this example was in the js-ipfs repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed. I copied this from the react example of js-ipfs, but did not read the comment: https:/ipfs/js-ipfs/blob/master/examples/browser-create-react-app/.env
It is aegir that installs a version of webpack that is not compatible with react-scripts. I am going to change that comment

@vasco-santos
Copy link
Member Author

After syncing with @jacobheun , we will start by having a public delegated router configured.

We were having some issues finding peer via the delegate because of the lack of support for HTTPS in the go-ipfs API. This needs to be properly configured using a reverse proxy and generated SSL certificates. I will create an issue to track adding documentation for infrastructure for going to production to unblock this PR for now.

@achingbrain
Copy link
Member

Superseded by #1390

@achingbrain achingbrain deleted the refactor/examples-delegated-routing branch September 22, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants