Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: createImageBitmap with ImageData is not implemented #43

Closed
frank-weindel opened this issue Oct 6, 2023 · 0 comments · Fixed by #46
Closed

TypeError: createImageBitmap with ImageData is not implemented #43

frank-weindel opened this issue Oct 6, 2023 · 0 comments · Fixed by #46
Assignees
@frank-weindel
Labels
bug Something isn't working legacy browser support Feature/fix relates to supporting older browsers

Comments

@frank-weindel
Copy link
Collaborator

frank-weindel commented Oct 6, 2023 •
edited
Loading

Got a report of this error occurring on XUMO boxes from @iamtabrezkhan on Discord:

Hey guys, I am running a very basic app on a XUMO box using just the renderer. No framework. Just initializing the renderer and creating a few rectangles using renderer.createNode.
Locally on browser it works fine. But in the box, I am getting this error - TypeError: createImageBitmap with ImageData is not implemented

I confirmed this issue occurs on pre-WPE 2.38 RDK devices.

I think we can solve this by allowing ImageData objects to be passed all the way through to the texImage2D() GPU upload call without first trying to convert them to ImageBitmap.
@frank-weindel frank-weindel added the bug Something isn't working label Oct 6, 2023
@frank-weindel frank-weindel self-assigned this Oct 6, 2023
@frank-weindel frank-weindel added the legacy browser support Feature/fix relates to supporting older browsers label Oct 6, 2023
frank-weindel added a commit that referenced this issue Oct 6, 2023
@frank-weindel
Remove reliance on createImageBitmap(ImageData)
fc0ee7d 
This browser feature lacks legacy support. Specifically WPE 2.28.

Fixes #43
@frank-weindel frank-weindel mentioned this issue Oct 6, 2023
Merged
@frank-weindel frank-weindel linked a pull request Oct 6, 2023 that will close this issue
WPE 2.28 support #46
Merged
frank-weindel added a commit that referenced this issue Oct 6, 2023
@frank-weindel
WPE 2.28 support (#46)
68da4d0 
- Fixes remaining issues when trying to run the Renderer on WPE 2.28 browser and possibly lower.
  - Tested on a production XG2v2 device.
  - For an application using the Renderer to work on this browser, its build target MUST be set to ES2019 or lower.
  - To run the Renderer Example Tests on legacy browsers, you must build/run the production version of the tests.
  - Fixes #43, #44, #45 
- Added `npm run prod` command to run the Example Tests in production mode (required to run the tests on legacy browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frank-weindel frank-weindel

Labels
bug Something isn't working legacy browser support Feature/fix relates to supporting older browsers
Projects
Lightning 3.0
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WPE 2.28 support lightning-js/renderer
1 participant
@frank-weindel