-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECMAScript Target missing for Example Tests #44
Labels
Comments
frank-weindel
added
bug
Something isn't working
legacy browser support
Feature/fix relates to supporting older browsers
labels
Oct 6, 2023
frank-weindel
added a commit
that referenced
this issue
Oct 6, 2023
Target set to ES2019 which seems to be supported by WPE 2.28. Fixes #44
Merged
Merged
frank-weindel
added a commit
that referenced
this issue
Oct 6, 2023
- Fixes remaining issues when trying to run the Renderer on WPE 2.28 browser and possibly lower. - Tested on a production XG2v2 device. - For an application using the Renderer to work on this browser, its build target MUST be set to ES2019 or lower. - To run the Renderer Example Tests on legacy browsers, you must build/run the production version of the tests. - Fixes #43, #44, #45 - Added `npm run prod` command to run the Example Tests in production mode (required to run the tests on legacy browsers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Currently the example tests have no defined ECMAScript / browser target so if you attempt to run them on a device running WPE 2.28 (for instance) errors like the following appear:
We need to define a target of ES2019 which is known to be supported by WPE 2.28.
In addition we need an easier way to run the production build of the examples. The dev build (via
npm start
) does not properly support the setting of a target. See this Vite issue and comment.Proposal is to create an
npm run prod
command in the root that:vite build
vite preview
The text was updated successfully, but these errors were encountered: