Allow debugging unminified source code. Update README.md #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| grunt.registerTask('releasePatch', ['bump-only:patch', 'buildRelease', 'shell:gitAddArchive', 'bump-commit']); | ||
| grunt.registerTask('releaseMinor', ['bump-only:minor', 'buildRelease', 'shell:gitAddArchive', 'bump-commit']); | ||
|
|
||
| //default task - full test | ||
| grunt.registerTask('default', ['test']); | ||
| grunt.registerTask('default', ['test']); |
There was a problem hiding this comment.
It might seem so :), but no, this is intentional. All of the task arrays are tab aligned, so it's easier to glance through them.
Take a look at the "Grunt tasks aliases" section at the bottom of the gruntfile, and you'll see what I'm talking about.
|
Looks good. |
prashn64
added a commit
that referenced
this pull request
Mar 27, 2014
Allow debugging unminified source code. Update README.md to explain these changes.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no clearly defined and documented way to debug unminified dust-helpers.js code. Adding this ability with
grunt testClienttask. It is the same approach as in main dust repo (although testClient task uses unminified source file there).Additionally coverage report generated by jasmine task was based on minified dust-helper.js file. It was hard to tell which lines were covered, since all of it was just one line. Moved out coverage task as a separate task and made it generate report based on unminified source code.
Added
grunt watchtask to be in line with main dust project and just because it's handy :)Also update README.md to provide instructions on how all of these tasks should be used.
With these updates travis build will run unit tests against minified dust helpers code in Phantom, Node and Rhino. It will also run coverage report against unminified source code. If coverage thresholds are not met, build will fail.